From 6811debb9da24f94a417d2bb425d3bdc07cb9e99 Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Fri, 9 Feb 2018 13:26:44 +0200 Subject: unit/test-ecc: Fix uninitialised values Conditional jump or move depends on uninitialised value(s) at 0x40208C: test_sample (test-ecc.c:106) by 0x4022AB: test_invalid_pub (test-ecc.c:272) by 0x406DA2: run_callback (tester.c:415) by 0x4E83576: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x4E86B76: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x4E86F1F: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x4E87231: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x408245: tester_run (tester.c:830) by 0x401CC3: main (test-ecc.c:291) Conditional jump or move depends on uninitialised value(s) at 0x4020D6: test_sample (test-ecc.c:113) by 0x4022AB: test_invalid_pub (test-ecc.c:272) by 0x406DA2: run_callback (tester.c:415) by 0x4E83576: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x4E86B76: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x4E86F1F: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x4E87231: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x408245: tester_run (tester.c:830) by 0x401CC3: main (test-ecc.c:291) --- unit/test-ecc.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'unit') diff --git a/unit/test-ecc.c b/unit/test-ecc.c index 98400a253..d9136814d 100644 --- a/unit/test-ecc.c +++ b/unit/test-ecc.c @@ -94,7 +94,10 @@ static int test_sample(uint8_t priv_a[32], uint8_t priv_b[32], uint8_t dhkey_a[32], dhkey_b[32]; int fails = 0; + memset(dhkey_a, 0, sizeof(dhkey_a)); ecdh_shared_secret(pub_b, priv_a, dhkey_a); + + memset(dhkey_b, 0, sizeof(dhkey_b)); ecdh_shared_secret(pub_a, priv_b, dhkey_b); if (g_test_verbose()) { @@ -110,6 +113,7 @@ static int test_sample(uint8_t priv_a[32], uint8_t priv_b[32], tester_debug("DHKey A matches :)"); } + if (memcmp(dhkey_b, dhkey, 32)) { tester_debug("DHKey B doesn't match!"); fails++; -- cgit v1.2.1