From f4dc05bf76fbb2c9c2561ff6d3bd3f018829ac3a Mon Sep 17 00:00:00 2001 From: Zach Brown Date: Wed, 23 Jan 2013 14:41:03 -0800 Subject: btrfs-progs: scrub can leak fd 0 < 0 is returned for errors opening the file, this code could leak fd 0. Signed-off-by: Zach Brown --- cmds-scrub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmds-scrub.c b/cmds-scrub.c index 70d2683..8655d3d 100644 --- a/cmds-scrub.c +++ b/cmds-scrub.c @@ -754,7 +754,7 @@ static int scrub_write_progress(pthread_mutex_t *m, const char *fsid, { int ret; int err; - int fd = 0; + int fd = -1; int old; ret = pthread_mutex_lock(m); @@ -782,7 +782,7 @@ static int scrub_write_progress(pthread_mutex_t *m, const char *fsid, goto out; out: - if (fd > 0) { + if (fd >= 0) { ret = close(fd); if (ret) err = -errno; -- cgit v1.2.1