From cb4c601a4e7cf33102a0667799eb0ec603067ee8 Mon Sep 17 00:00:00 2001 From: Zach Brown Date: Wed, 23 Jan 2013 14:36:03 -0800 Subject: btrfs-progs: fix scrub socket leak If connection fails the socket is leaked when the status file is used instead. Close it to trivially cut down on fd use and to bring down the noise in static code analysis. Signed-off-by: Zach Brown --- cmds-scrub.c | 1 + 1 file changed, 1 insertion(+) (limited to 'cmds-scrub.c') diff --git a/cmds-scrub.c b/cmds-scrub.c index efdfdb4..70d2683 100644 --- a/cmds-scrub.c +++ b/cmds-scrub.c @@ -1584,6 +1584,7 @@ static int cmd_scrub_status(int argc, char **argv) addr.sun_path[sizeof(addr.sun_path) - 1] = '\0'; ret = connect(fdres, (struct sockaddr *)&addr, sizeof(addr)); if (ret == -1) { + close(fdres); fdres = scrub_open_file_r(SCRUB_DATA_FILE, fsid); if (fdres < 0 && fdres != -ENOENT) { fprintf(stderr, "WARNING: failed to open status file: " -- cgit v1.2.1