<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/buildstream.git, branch bschubert/pylint-artifactcache</title>
<subtitle>gitlab.com: buildstream/buildstream.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/'/>
<entry>
<title>tests/artifactcache: add __init__.py file to make it a package</title>
<updated>2019-06-06T12:16:36+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-05T17:39:24+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=a729dd63ded98c6adefaa75a01f5ff88f79ed83d'/>
<id>a729dd63ded98c6adefaa75a01f5ff88f79ed83d</id>
<content type='text'>
tests/integration was lacking a __init__.py file, meaning it was not
recognized as a python package, and thus, pylint would not check
anything inside the directory.

Adding __init__.py ensures we have correct checks here.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
tests/integration was lacking a __init__.py file, meaning it was not
recognized as a python package, and thus, pylint would not check
anything inside the directory.

Adding __init__.py ensures we have correct checks here.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/artifactcache/push: remove unused import</title>
<updated>2019-06-06T12:16:36+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-05T17:38:39+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=e7d248423d19f14e098a27795dd6b86e58db08f6'/>
<id>e7d248423d19f14e098a27795dd6b86e58db08f6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/artifactcache/pull: Remove unused variable</title>
<updated>2019-06-06T12:16:36+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-05T17:38:16+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=cf74b1189f275acd95a7dd2dbe6fd96c8dc00c9e'/>
<id>cf74b1189f275acd95a7dd2dbe6fd96c8dc00c9e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/artifactcache/config: Fix pylint issues</title>
<updated>2019-06-06T12:16:36+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-05T17:37:38+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=f036f0220186e7f79d329eefa12644f4550f1547'/>
<id>f036f0220186e7f79d329eefa12644f4550f1547</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/artifactcache/artifactservice: Fix pylint issues</title>
<updated>2019-06-06T12:16:36+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-05T17:32:05+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=e57f4d02062386ba8672527e0b4234fba1cb72bd'/>
<id>e57f4d02062386ba8672527e0b4234fba1cb72bd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/artifactcache: Disable 'unused-import' checks that are pytest fixtures</title>
<updated>2019-06-06T12:16:36+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-05T17:26:55+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=3cc5ae4b3d55ff381f2d480efe3b8f2c861d6634'/>
<id>3cc5ae4b3d55ff381f2d480efe3b8f2c861d6634</id>
<content type='text'>
Some imports are fixtures, that need to be in the current namespace when
pytest runs. However, pylint does not know this.

Disabling pylint checks on those imports
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some imports are fixtures, that need to be in the current namespace when
pytest runs. However, pylint does not know this.

Disabling pylint checks on those imports
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/artifactcache: Silence all 'redefined-outer-name' pylint errors</title>
<updated>2019-06-06T12:16:36+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-05T17:19:58+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=d26ed64ce2df93979a4532e35c3dc817b78a45aa'/>
<id>d26ed64ce2df93979a4532e35c3dc817b78a45aa</id>
<content type='text'>
This is due to pytest fixtures having to be named the same as the test
arguments.

This is a pre-requisite to enable pylint on this directory

We need to do this per file as we can't blanket disable for directories.
See upstream issue: https://github.com/PyCQA/pylint/issues/618
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is due to pytest fixtures having to be named the same as the test
arguments.

This is a pre-requisite to enable pylint on this directory

We need to do this per file as we can't blanket disable for directories.
See upstream issue: https://github.com/PyCQA/pylint/issues/618
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'aevri/defensive_send_message' into 'master'</title>
<updated>2019-06-06T12:15:32+00:00</updated>
<author>
<name>bst-marge-bot</name>
<email>marge-bot@buildstream.build</email>
</author>
<published>2019-06-06T12:15:32+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=0b7a9f3e48d1cfcdd16ca01f3b8643a1c1753876'/>
<id>0b7a9f3e48d1cfcdd16ca01f3b8643a1c1753876</id>
<content type='text'>
_scheduler/jobs: refactor, defensive send_message

See merge request BuildStream/buildstream!1373</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
_scheduler/jobs: refactor, defensive send_message

See merge request BuildStream/buildstream!1373</pre>
</div>
</content>
</entry>
<entry>
<title>_scheduler/jobs: refactor, defensive send_message</title>
<updated>2019-06-06T11:34:55+00:00</updated>
<author>
<name>Angelos Evripiotis</name>
<email>jevripiotis@bloomberg.net</email>
</author>
<published>2019-06-05T13:37:33+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=03901dd8ef38755f8f9530c51329baf7e10cbf8c'/>
<id>03901dd8ef38755f8f9530c51329baf7e10cbf8c</id>
<content type='text'>
Simplify the custom 'handle_message' / 'send_message' protocol by not
requiring a message_type. These message types share a namespace with the
base Job implementation, which could cause trouble.

Introduce a new private '_send_message' to implement the old
functionality.

Subclasses are free to pack a message type into their own messages, this
isn't necessary at present and simplifies existing subclass code.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Simplify the custom 'handle_message' / 'send_message' protocol by not
requiring a message_type. These message types share a namespace with the
base Job implementation, which could cause trouble.

Introduce a new private '_send_message' to implement the old
functionality.

Subclasses are free to pack a message type into their own messages, this
isn't necessary at present and simplifies existing subclass code.
</pre>
</div>
</content>
</entry>
<entry>
<title>jobs/job: lint fixes, overhang + unused var</title>
<updated>2019-06-06T11:34:55+00:00</updated>
<author>
<name>Angelos Evripiotis</name>
<email>jevripiotis@bloomberg.net</email>
</author>
<published>2019-06-05T12:48:08+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/buildstream.git/commit/?id=20152018cb66d4c5d1d0031c74b27fdaa30a8d5e'/>
<id>20152018cb66d4c5d1d0031c74b27fdaa30a8d5e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
