diff options
author | Josh Smith <qinusty@gmail.com> | 2018-09-07 16:47:01 +0100 |
---|---|---|
committer | Josh Smith <qinusty@gmail.com> | 2018-09-12 15:44:38 +0100 |
commit | 027f500446102c2300dc436a205d4f141dac23d3 (patch) | |
tree | c84265489997ed44692eed2904481e20114be2f9 | |
parent | 8860fbfad36b17620713db2d591669b44fffdf2f (diff) | |
download | buildstream-027f500446102c2300dc436a205d4f141dac23d3.tar.gz |
element.py: Remove redundant timed_activity
This removes the timed_activity for an element _push action. This is
unnecessary as the job is already being timed elsewhere.
-rw-r--r-- | buildstream/element.py | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/buildstream/element.py b/buildstream/element.py index 553973d0c..654c859ab 100644 --- a/buildstream/element.py +++ b/buildstream/element.py @@ -1798,16 +1798,15 @@ class Element(Plugin): self.warn("Not pushing tainted artifact.") return False - display_key = self._get_brief_display_key() - with self.timed_activity("Pushing artifact {}".format(display_key)): - # Push all keys used for local commit - pushed = self.__artifacts.push(self, self.__get_cache_keys_for_commit()) - if not pushed: - return False + # Push all keys used for local commit + pushed = self.__artifacts.push(self, self.__get_cache_keys_for_commit()) + if not pushed: + return False - # Notify successful upload - self.info("Pushed artifact {}".format(display_key)) - return True + # Notify successful upload + display_key = self._get_brief_display_key() + self.info("Pushed artifact {}".format(display_key)) + return True # _shell(): # |