tests:lint: silence redefined-outer-name in files using fixtures

Pylint doesn't play well with pytest fixtures, we therefore need to
silence this error.

75 files changed, 230 insertions, 0 deletions

diff --git a/tests/cachekey/cachekey.py b/tests/cachekey/cachekey.py
index 038aacc4f..2f4ed8c43 100644
--- a/tests/cachekey/cachekey.py
+++ b/tests/cachekey/cachekey.py
@@ -35,6 +35,10 @@
 # run over to the corresponding .expected source files and commit
 # the result.
 #
+
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 from collections import OrderedDict
 import os
 
diff --git a/tests/elements/filter.py b/tests/elements/filter.py
index 4810265ab..2a86d4d37 100644
--- a/tests/elements/filter.py
+++ b/tests/elements/filter.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import shutil
 
diff --git a/tests/examples/autotools.py b/tests/examples/autotools.py
index d653cdcd2..16132cf45 100644
--- a/tests/examples/autotools.py
+++ b/tests/examples/autotools.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/examples/developing.py b/tests/examples/developing.py
index 86046a0b8..46f0d7f30 100644
--- a/tests/examples/developing.py
+++ b/tests/examples/developing.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/examples/first-project.py b/tests/examples/first-project.py
index efbea4d0c..34901f260 100644
--- a/tests/examples/first-project.py
+++ b/tests/examples/first-project.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/examples/flatpak-autotools.py b/tests/examples/flatpak-autotools.py
index 44b0ef93d..d08808886 100644
--- a/tests/examples/flatpak-autotools.py
+++ b/tests/examples/flatpak-autotools.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/examples/integration-commands.py b/tests/examples/integration-commands.py
index bbcaafbfd..46ad79323 100644
--- a/tests/examples/integration-commands.py
+++ b/tests/examples/integration-commands.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/examples/junctions.py b/tests/examples/junctions.py
index 777bf71a0..0d9e18fd2 100644
--- a/tests/examples/junctions.py
+++ b/tests/examples/junctions.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/examples/running-commands.py b/tests/examples/running-commands.py
index 677b14654..ecdb13793 100644
--- a/tests/examples/running-commands.py
+++ b/tests/examples/running-commands.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/format/assertion.py b/tests/format/assertion.py
index b787e07fc..7eeec3837 100644
--- a/tests/format/assertion.py
+++ b/tests/format/assertion.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream._exceptions import ErrorDomain, LoadErrorReason
diff --git a/tests/format/dependencies.py b/tests/format/dependencies.py
index 8557ef64e..f056e0564 100644
--- a/tests/format/dependencies.py
+++ b/tests/format/dependencies.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/format/include.py b/tests/format/include.py
index c4fa9adb5..133b7ac2c 100644
--- a/tests/format/include.py
+++ b/tests/format/include.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import textwrap
 import pytest
diff --git a/tests/format/junctions.py b/tests/format/junctions.py
index 52c76e0f3..89789f7eb 100644
--- a/tests/format/junctions.py
+++ b/tests/format/junctions.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import shutil
 
diff --git a/tests/format/listdirectiveerrors.py b/tests/format/listdirectiveerrors.py
index 463d00815..10e0b655a 100644
--- a/tests/format/listdirectiveerrors.py
+++ b/tests/format/listdirectiveerrors.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream._exceptions import ErrorDomain, LoadErrorReason
diff --git a/tests/format/optionarch.py b/tests/format/optionarch.py
index 0b5f05569..235e5e247 100644
--- a/tests/format/optionarch.py
+++ b/tests/format/optionarch.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 from contextlib import contextmanager
 import os
 
diff --git a/tests/format/optionbool.py b/tests/format/optionbool.py
index 598496cd3..e0642672b 100644
--- a/tests/format/optionbool.py
+++ b/tests/format/optionbool.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream import _yaml
diff --git a/tests/format/optioneltmask.py b/tests/format/optioneltmask.py
index 7cbbd88f4..c08d8329f 100644
--- a/tests/format/optioneltmask.py
+++ b/tests/format/optioneltmask.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream import _yaml
diff --git a/tests/format/optionenum.py b/tests/format/optionenum.py
index 936126dfc..7e09e5f7a 100644
--- a/tests/format/optionenum.py
+++ b/tests/format/optionenum.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream import _yaml
diff --git a/tests/format/optionexports.py b/tests/format/optionexports.py
index 5e65e9721..f9653301b 100644
--- a/tests/format/optionexports.py
+++ b/tests/format/optionexports.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream import _yaml
diff --git a/tests/format/optionflags.py b/tests/format/optionflags.py
index 341bb8c80..2a0c2b8ce 100644
--- a/tests/format/optionflags.py
+++ b/tests/format/optionflags.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream import _yaml
diff --git a/tests/format/optionos.py b/tests/format/optionos.py
index 3ab5ccb81..361be9ec2 100644
--- a/tests/format/optionos.py
+++ b/tests/format/optionos.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 from contextlib import contextmanager
 import os
 
diff --git a/tests/format/optionoverrides.py b/tests/format/optionoverrides.py
index 256562edf..7336a5a2d 100644
--- a/tests/format/optionoverrides.py
+++ b/tests/format/optionoverrides.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream import _yaml
diff --git a/tests/format/options.py b/tests/format/options.py
index 3a1b12877..ff77fa540 100644
--- a/tests/format/options.py
+++ b/tests/format/options.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream import _yaml
diff --git a/tests/format/project.py b/tests/format/project.py
index ee621a162..0d00b2ecf 100644
--- a/tests/format/project.py
+++ b/tests/format/project.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream import _yaml
diff --git a/tests/format/projectoverrides.py b/tests/format/projectoverrides.py
index cf9a1d35e..286f31312 100644
--- a/tests/format/projectoverrides.py
+++ b/tests/format/projectoverrides.py
@@ -1,3 +1,5 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
 
 import os
 import pytest
diff --git a/tests/format/variables.py b/tests/format/variables.py
index 688452541..4d30c6e08 100644
--- a/tests/format/variables.py
+++ b/tests/format/variables.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import sys
 
diff --git a/tests/frontend/artifact.py b/tests/frontend/artifact.py
index b6f8fb91d..6e549772d 100644
--- a/tests/frontend/artifact.py
+++ b/tests/frontend/artifact.py
@@ -18,6 +18,9 @@
 #  Authors: Richard Maw <richard.maw@codethink.co.uk>
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/frontend/buildcheckout.py b/tests/frontend/buildcheckout.py
index a04edf6ee..e440500bc 100644
--- a/tests/frontend/buildcheckout.py
+++ b/tests/frontend/buildcheckout.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import tarfile
 import hashlib
diff --git a/tests/frontend/buildtrack.py b/tests/frontend/buildtrack.py
index 9c3efadd8..8ce17f7e7 100644
--- a/tests/frontend/buildtrack.py
+++ b/tests/frontend/buildtrack.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import re
 import shutil
diff --git a/tests/frontend/completions.py b/tests/frontend/completions.py
index 6c737924d..84f57a86b 100644
--- a/tests/frontend/completions.py
+++ b/tests/frontend/completions.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream.plugintestutils import cli
diff --git a/tests/frontend/compose_splits.py b/tests/frontend/compose_splits.py
index 3d2db44fb..560ce0e75 100644
--- a/tests/frontend/compose_splits.py
+++ b/tests/frontend/compose_splits.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream.plugintestutils.runcli import cli
diff --git a/tests/frontend/configurable_warnings.py b/tests/frontend/configurable_warnings.py
index 2de94186f..5e951fa8d 100644
--- a/tests/frontend/configurable_warnings.py
+++ b/tests/frontend/configurable_warnings.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 
 import pytest
diff --git a/tests/frontend/cross_junction_workspace.py b/tests/frontend/cross_junction_workspace.py
index 491399fe6..a63573b20 100644
--- a/tests/frontend/cross_junction_workspace.py
+++ b/tests/frontend/cross_junction_workspace.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 from buildstream.plugintestutils import cli
 from buildstream import _yaml
diff --git a/tests/frontend/fetch.py b/tests/frontend/fetch.py
index 56bc551b6..0ace237bf 100644
--- a/tests/frontend/fetch.py
+++ b/tests/frontend/fetch.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/frontend/help.py b/tests/frontend/help.py
index 540a3a60f..0b30e47b4 100644
--- a/tests/frontend/help.py
+++ b/tests/frontend/help.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import pytest
 from buildstream.plugintestutils.runcli import cli
 
diff --git a/tests/frontend/init.py b/tests/frontend/init.py
index e5cab87fa..9cc4cd414 100644
--- a/tests/frontend/init.py
+++ b/tests/frontend/init.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream.plugintestutils import cli
diff --git a/tests/frontend/logging.py b/tests/frontend/logging.py
index 1fbd57e7d..9264bf7a8 100644
--- a/tests/frontend/logging.py
+++ b/tests/frontend/logging.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import re
 
diff --git a/tests/frontend/mirror.py b/tests/frontend/mirror.py
index 3f1d7181f..1df328b39 100644
--- a/tests/frontend/mirror.py
+++ b/tests/frontend/mirror.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/frontend/order.py b/tests/frontend/order.py
index 7982d993d..1478fe92a 100644
--- a/tests/frontend/order.py
+++ b/tests/frontend/order.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 
 import pytest
diff --git a/tests/frontend/overlaps.py b/tests/frontend/overlaps.py
index b58ac6bcd..b056cbb59 100644
--- a/tests/frontend/overlaps.py
+++ b/tests/frontend/overlaps.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream.plugintestutils.runcli import cli
diff --git a/tests/frontend/pull.py b/tests/frontend/pull.py
index dbc577641..d60398623 100644
--- a/tests/frontend/pull.py
+++ b/tests/frontend/pull.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import shutil
 import stat
diff --git a/tests/frontend/push.py b/tests/frontend/push.py
index ab15822bc..be08a903b 100644
--- a/tests/frontend/push.py
+++ b/tests/frontend/push.py
@@ -20,6 +20,9 @@
 #           Jürg Billeter <juerg.billeter@codethink.co.uk>
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/frontend/rebuild.py b/tests/frontend/rebuild.py
index 5688f158e..e234f54a4 100644
--- a/tests/frontend/rebuild.py
+++ b/tests/frontend/rebuild.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 from buildstream.plugintestutils import cli
diff --git a/tests/frontend/show.py b/tests/frontend/show.py
index a98893e68..352b9a96e 100644
--- a/tests/frontend/show.py
+++ b/tests/frontend/show.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import sys
 import shutil
diff --git a/tests/frontend/source_checkout.py b/tests/frontend/source_checkout.py
index 0b38959db..569d913a7 100644
--- a/tests/frontend/source_checkout.py
+++ b/tests/frontend/source_checkout.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import tarfile
 
diff --git a/tests/frontend/track.py b/tests/frontend/track.py
index 322e9ad08..011bd9bd1 100644
--- a/tests/frontend/track.py
+++ b/tests/frontend/track.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import stat
 import os
 import pytest
diff --git a/tests/frontend/version.py b/tests/frontend/version.py
index 1d36a33b5..f74000a21 100644
--- a/tests/frontend/version.py
+++ b/tests/frontend/version.py
@@ -1,5 +1,9 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 from buildstream.plugintestutils.runcli import cli
 
+
 # For utils.get_bst_version()
 from buildstream import utils
 
diff --git a/tests/frontend/workspace.py b/tests/frontend/workspace.py
index 04071e0d4..38f0dcb58 100644
--- a/tests/frontend/workspace.py
+++ b/tests/frontend/workspace.py
@@ -24,6 +24,9 @@
 #           William Salmon <will.salmon@codethink.co.uk>
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import stat
 import shutil
diff --git a/tests/frontend/yamlcache.py b/tests/frontend/yamlcache.py
index f3a6dda41..3841675d1 100644
--- a/tests/frontend/yamlcache.py
+++ b/tests/frontend/yamlcache.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 from contextlib import contextmanager
 import os
 import tempfile
diff --git a/tests/internals/context.py b/tests/internals/context.py
index cf9d4f4c4..82d600133 100644
--- a/tests/internals/context.py
+++ b/tests/internals/context.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/internals/pluginfactory.py b/tests/internals/pluginfactory.py
index ec30c8b0a..d46c13e36 100644
--- a/tests/internals/pluginfactory.py
+++ b/tests/internals/pluginfactory.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/internals/utils_move_atomic.py b/tests/internals/utils_move_atomic.py
index 6edbec611..cda020809 100644
--- a/tests/internals/utils_move_atomic.py
+++ b/tests/internals/utils_move_atomic.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import pytest
 
 from buildstream.utils import move_atomic, DirectoryExistsError
diff --git a/tests/sourcecache/config.py b/tests/sourcecache/config.py
index b5581a7e2..4ba68a0c5 100644
--- a/tests/sourcecache/config.py
+++ b/tests/sourcecache/config.py
@@ -17,6 +17,10 @@
 #  Authors:
 #        Raoul Hidalgo Charman <raoul.hidalgocharman@codethink.co.uk>
 #
+
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sourcecache/source-checkout.py b/tests/sourcecache/source-checkout.py
index b2333c993..3eee993da 100644
--- a/tests/sourcecache/source-checkout.py
+++ b/tests/sourcecache/source-checkout.py
@@ -17,6 +17,10 @@
 #  Authors:
 #        Raoul Hidalgo Charman <raoul.hidalgocharman@codethink.co.uk>
 #
+
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import shutil
 
diff --git a/tests/sourcecache/staging.py b/tests/sourcecache/staging.py
index 757839caa..863b6a25b 100644
--- a/tests/sourcecache/staging.py
+++ b/tests/sourcecache/staging.py
@@ -17,6 +17,10 @@
 #  Authors:
 #        Raoul Hidalgo Charman <raoul.hidalgocharman@codethink.co.uk>
 #
+
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import shutil
 import pytest
diff --git a/tests/sourcecache/workspace.py b/tests/sourcecache/workspace.py
index 587386134..cfc4ac744 100644
--- a/tests/sourcecache/workspace.py
+++ b/tests/sourcecache/workspace.py
@@ -17,6 +17,10 @@
 #  Authors:
 #        Raoul Hidalgo Charman <raoul.hidalgocharman@codethink.co.uk>
 #
+
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import shutil
 
diff --git a/tests/sources/bzr.py b/tests/sources/bzr.py
index 3ff51bc2e..7434502c1 100644
--- a/tests/sources/bzr.py
+++ b/tests/sources/bzr.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/deb.py b/tests/sources/deb.py
index 554110319..db9666bf5 100644
--- a/tests/sources/deb.py
+++ b/tests/sources/deb.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import shutil
 
diff --git a/tests/sources/generic/build_checkout.py b/tests/sources/generic/build_checkout.py
index 14a2bc142..5aaedb9d6 100644
--- a/tests/sources/generic/build_checkout.py
+++ b/tests/sources/generic/build_checkout.py
@@ -16,6 +16,9 @@
 #  License along with this library. If not, see <http://www.gnu.org/licenses/>.
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/generic/fetch.py b/tests/sources/generic/fetch.py
index bdb8b8970..2a6fa3d85 100644
--- a/tests/sources/generic/fetch.py
+++ b/tests/sources/generic/fetch.py
@@ -16,6 +16,9 @@
 #  License along with this library. If not, see <http://www.gnu.org/licenses/>.
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/generic/mirror.py b/tests/sources/generic/mirror.py
index a1967b6c5..d5f016333 100644
--- a/tests/sources/generic/mirror.py
+++ b/tests/sources/generic/mirror.py
@@ -16,6 +16,9 @@
 #  License along with this library. If not, see <http://www.gnu.org/licenses/>.
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/generic/source_determinism.py b/tests/sources/generic/source_determinism.py
index 98c4c9835..d0c33e4b7 100644
--- a/tests/sources/generic/source_determinism.py
+++ b/tests/sources/generic/source_determinism.py
@@ -16,6 +16,9 @@
 #  License along with this library. If not, see <http://www.gnu.org/licenses/>.
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/generic/track.py b/tests/sources/generic/track.py
index 9764bfe76..a313de167 100644
--- a/tests/sources/generic/track.py
+++ b/tests/sources/generic/track.py
@@ -16,6 +16,9 @@
 #  License along with this library. If not, see <http://www.gnu.org/licenses/>.
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/generic/track_cross_junction.py b/tests/sources/generic/track_cross_junction.py
index 94f718d43..257a42240 100644
--- a/tests/sources/generic/track_cross_junction.py
+++ b/tests/sources/generic/track_cross_junction.py
@@ -16,6 +16,9 @@
 #  License along with this library. If not, see <http://www.gnu.org/licenses/>.
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/generic/workspace.py b/tests/sources/generic/workspace.py
index d332a6ef6..b61afbe96 100644
--- a/tests/sources/generic/workspace.py
+++ b/tests/sources/generic/workspace.py
@@ -16,6 +16,9 @@
 #  License along with this library. If not, see <http://www.gnu.org/licenses/>.
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import shutil
 import pytest
diff --git a/tests/sources/git.py b/tests/sources/git.py
index debbb04ab..d252a15c3 100644
--- a/tests/sources/git.py
+++ b/tests/sources/git.py
@@ -20,6 +20,9 @@
 #           William Salmon <will.salmon@codethink.co.uk>
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import subprocess
 import shutil
diff --git a/tests/sources/local.py b/tests/sources/local.py
index 7df1cd9ea..459db1232 100644
--- a/tests/sources/local.py
+++ b/tests/sources/local.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/no_fetch_cached.py b/tests/sources/no_fetch_cached.py
index 9ef838cf4..d80645c87 100644
--- a/tests/sources/no_fetch_cached.py
+++ b/tests/sources/no_fetch_cached.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/ostree.py b/tests/sources/ostree.py
index e2d6b6a0f..fe517883e 100644
--- a/tests/sources/ostree.py
+++ b/tests/sources/ostree.py
@@ -17,6 +17,9 @@
 #  Authors: William Salmon <will.salmon@codethink.co.uk>
 #
 
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/patch.py b/tests/sources/patch.py
index 51cdc2186..75bec9717 100644
--- a/tests/sources/patch.py
+++ b/tests/sources/patch.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/pip.py b/tests/sources/pip.py
index 7ff547b14..5969748d7 100644
--- a/tests/sources/pip.py
+++ b/tests/sources/pip.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/previous_source_access.py b/tests/sources/previous_source_access.py
index efea86339..5a020af23 100644
--- a/tests/sources/previous_source_access.py
+++ b/tests/sources/previous_source_access.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import pytest
 
diff --git a/tests/sources/remote.py b/tests/sources/remote.py
index 48e8c3df5..e1c70f8f1 100644
--- a/tests/sources/remote.py
+++ b/tests/sources/remote.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import stat
 import pytest
diff --git a/tests/sources/tar.py b/tests/sources/tar.py
index ed99036b2..a6dfa05c5 100644
--- a/tests/sources/tar.py
+++ b/tests/sources/tar.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 from shutil import copyfile, rmtree
 import subprocess
diff --git a/tests/sources/zip.py b/tests/sources/zip.py
index 64ef61c21..4df81ca29 100644
--- a/tests/sources/zip.py
+++ b/tests/sources/zip.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
 import os
 import zipfile