summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenjamin Schubert <ben.c.schubert@gmail.com>2019-06-05 18:19:58 +0100
committerbst-marge-bot <marge-bot@buildstream.build>2019-06-06 12:16:36 +0000
commitd26ed64ce2df93979a4532e35c3dc817b78a45aa (patch)
treee1a642e34f13104eeaabbae2a8b674b682a11c90
parent0b7a9f3e48d1cfcdd16ca01f3b8643a1c1753876 (diff)
downloadbuildstream-d26ed64ce2df93979a4532e35c3dc817b78a45aa.tar.gz
tests/artifactcache: Silence all 'redefined-outer-name' pylint errors
This is due to pytest fixtures having to be named the same as the test arguments. This is a pre-requisite to enable pylint on this directory We need to do this per file as we can't blanket disable for directories. See upstream issue: https://github.com/PyCQA/pylint/issues/618
-rw-r--r--tests/artifactcache/cache_size.py3
-rw-r--r--tests/artifactcache/config.py3
-rw-r--r--tests/artifactcache/expiry.py3
-rw-r--r--tests/artifactcache/junctions.py3
-rw-r--r--tests/artifactcache/pull.py3
-rw-r--r--tests/artifactcache/push.py3
6 files changed, 18 insertions, 0 deletions
diff --git a/tests/artifactcache/cache_size.py b/tests/artifactcache/cache_size.py
index 09f0f25d0..250094746 100644
--- a/tests/artifactcache/cache_size.py
+++ b/tests/artifactcache/cache_size.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
import os
from unittest import mock
diff --git a/tests/artifactcache/config.py b/tests/artifactcache/config.py
index 8adbb3274..39d8b9da3 100644
--- a/tests/artifactcache/config.py
+++ b/tests/artifactcache/config.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
import pytest
import itertools
diff --git a/tests/artifactcache/expiry.py b/tests/artifactcache/expiry.py
index 6aa518f1a..c67884046 100644
--- a/tests/artifactcache/expiry.py
+++ b/tests/artifactcache/expiry.py
@@ -17,6 +17,9 @@
# Authors: Tristan Maat <tristan.maat@codethink.co.uk>
#
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
import os
import re
from unittest import mock
diff --git a/tests/artifactcache/junctions.py b/tests/artifactcache/junctions.py
index e1bbb31fd..8e38f26e1 100644
--- a/tests/artifactcache/junctions.py
+++ b/tests/artifactcache/junctions.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
import os
import shutil
import pytest
diff --git a/tests/artifactcache/pull.py b/tests/artifactcache/pull.py
index cdadf583a..eafcec64b 100644
--- a/tests/artifactcache/pull.py
+++ b/tests/artifactcache/pull.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
import multiprocessing
import os
import signal
diff --git a/tests/artifactcache/push.py b/tests/artifactcache/push.py
index 4f31148b7..a49ee32d2 100644
--- a/tests/artifactcache/push.py
+++ b/tests/artifactcache/push.py
@@ -1,3 +1,6 @@
+# Pylint doesn't play well with fixtures and dependency injection from pytest
+# pylint: disable=redefined-outer-name
+
import multiprocessing
import os
import signal