diff options
| author | Benjamin Schubert <contact@benschubert.me> | 2019-11-08 12:29:19 +0000 |
|---|---|---|
| committer | bst-marge-bot <marge-bot@buildstream.build> | 2019-11-11 17:57:00 +0000 |
| commit | 3d1fb3bd3fe68826ee59bc466364e2407f75cfd8 (patch) | |
| tree | e599e792e5d435130574c945fb1f8d47d23921d9 | |
| parent | 278d010b873b59aa5eed577cb92dd1342a6f6f34 (diff) | |
| download | buildstream-3d1fb3bd3fe68826ee59bc466364e2407f75cfd8.tar.gz | |
scheduler.py: Remove FIXME message and add explanation instead
| -rw-r--r-- | src/buildstream/_scheduler/scheduler.py | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/buildstream/_scheduler/scheduler.py b/src/buildstream/_scheduler/scheduler.py index d3faa2a8e..7ef5c5fe3 100644 --- a/src/buildstream/_scheduler/scheduler.py +++ b/src/buildstream/_scheduler/scheduler.py @@ -478,11 +478,9 @@ class Scheduler(): # def _interrupt_event(self): - # FIXME: This should not be needed, but for some reason we receive an - # additional SIGINT event when the user hits ^C a second time - # to inform us that they really intend to terminate; even though - # we have disconnected our handlers at this time. - # + # The event loop receives a copy of all signals that are sent while it is running + # This means that even though we catch the SIGINT in the question to the user, + # the loop will receive it too, and thus we need to skip it here. if self.terminated: return |