summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJürg Billeter <j@bitron.ch>2019-03-02 12:07:10 +0100
committerbst-marge-bot <marge-bot@buildstream.build>2019-03-08 14:55:39 +0000
commit0f124fc2fb8f1b22f892f2e2f3a9703775a7aaa1 (patch)
tree0a9cabda4fb27698d39163fdacc69440280922c7
parent213310e3e1890859ba5c93b15c8bdbfcafb86cd4 (diff)
downloadbuildstream-0f124fc2fb8f1b22f892f2e2f3a9703775a7aaa1.tar.gz
_sandboxremote.py: Process job output for failed commands
The sandbox directory should be updated even for commands with non-zero exit code. This allows caching the failed buildtree for debugging.
-rw-r--r--buildstream/sandbox/_sandboxremote.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/buildstream/sandbox/_sandboxremote.py b/buildstream/sandbox/_sandboxremote.py
index 9e58b095a..d49f31133 100644
--- a/buildstream/sandbox/_sandboxremote.py
+++ b/buildstream/sandbox/_sandboxremote.py
@@ -354,6 +354,9 @@ class SandboxRemote(Sandbox):
operation = self.run_remote_command(channel, action_digest)
action_result = self._extract_action_result(operation)
+ # Get output of build
+ self.process_job_output(action_result.output_directories, action_result.output_files)
+
if action_result.exit_code != 0:
# A normal error during the build: the remote execution system
# has worked correctly but the command failed.
@@ -361,9 +364,6 @@ class SandboxRemote(Sandbox):
# build command outputs which we ignore at the moment.
return action_result.exit_code
- # Get output of build
- self.process_job_output(action_result.output_directories, action_result.output_files)
-
return 0
def _check_action_cache(self, action_digest):