summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTristan Van Berkom <tristan.vanberkom@codethink.co.uk>2018-04-12 23:47:52 +0900
committerTristan Van Berkom <tristan.vanberkom@codethink.co.uk>2018-04-13 00:01:36 +0900
commit522d6538410ca97627500d76f4aaca3d7b0c1608 (patch)
tree62abcb5c85de56fd30850b018d2f4315e261bc8e
parent39c4cd17b02f627c2a6c9c3d53fafedac8091e45 (diff)
downloadbuildstream-522d6538410ca97627500d76f4aaca3d7b0c1608.tar.gz
_scheduler/trackqueue.py: Mark skipped elements as tracked.
This ensures their state will be updated, it is especially important for sourceless elements which are scheduled to be tracked, like stack elements. This fixes a regression from my previous refactor or Sources which added Element._tracking_done()
-rw-r--r--buildstream/_scheduler/trackqueue.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/buildstream/_scheduler/trackqueue.py b/buildstream/_scheduler/trackqueue.py
index 5832e4602..fe5843148 100644
--- a/buildstream/_scheduler/trackqueue.py
+++ b/buildstream/_scheduler/trackqueue.py
@@ -41,6 +41,9 @@ class TrackQueue(Queue):
def status(self, element):
# We can skip elements entirely if they have no sources.
if not list(element.sources()):
+
+ # But we still have to mark them as tracked
+ element._tracking_done()
return QueueStatus.SKIP
return QueueStatus.READY