summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames Ennis <james.ennis@codethink.com>2018-02-14 17:42:18 +0000
committerJames Ennis <james.ennis@codethink.com>2018-03-14 17:31:06 +0000
commit432ddffdcb917e2b5a70b2cce0459be1b5881ad1 (patch)
treed62670fb6adecc495ac4b218130eb1e2e1b53d6f
parent9b4f54e1f8f1d064faaa51a5f480cb890892fb54 (diff)
downloadbuildstream-432ddffdcb917e2b5a70b2cce0459be1b5881ad1.tar.gz
pylint - dealt with unnecessary-pass warning
-rw-r--r--.pylintrc1
-rw-r--r--buildstream/utils.py2
2 files changed, 1 insertions, 2 deletions
diff --git a/.pylintrc b/.pylintrc
index 17e3cce35..3d7373cf8 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -114,7 +114,6 @@ disable=#####################################
logging-format-interpolation,
- unnecessary-pass,
cyclic-import,
# These are hard to spot without linting, but easy to fix
diff --git a/buildstream/utils.py b/buildstream/utils.py
index bd68522ad..a0c5eeba7 100644
--- a/buildstream/utils.py
+++ b/buildstream/utils.py
@@ -255,7 +255,7 @@ def safe_copy(src, dest, *, result=None):
# over extended file attributes.
if result:
result.failed_attributes.append(dest)
- pass
+
except shutil.Error as e:
raise UtilError("Failed to copy '{} -> {}': {}"
.format(src, dest, e)) from e