summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJosh Smith <qinusty@gmail.com>2018-09-07 16:47:01 +0100
committerJosh Smith <qinusty@gmail.com>2018-09-19 10:25:21 +0100
commitab56f693000f979f2c65ef6a85e3fb62256c2a06 (patch)
tree2c894e3b14a4451d57008c8bc69f92ed17f05d0b
parent16fbc3e3504290bded24d6fb40e3816741fa035a (diff)
downloadbuildstream-ab56f693000f979f2c65ef6a85e3fb62256c2a06.tar.gz
element.py: Remove redundant timed_activity
This removes the timed_activity for an element _push action. This is unnecessary as the job is already being timed elsewhere.
-rw-r--r--buildstream/element.py17
1 files changed, 8 insertions, 9 deletions
diff --git a/buildstream/element.py b/buildstream/element.py
index 13d76dbad..d87e26a64 100644
--- a/buildstream/element.py
+++ b/buildstream/element.py
@@ -1800,16 +1800,15 @@ class Element(Plugin):
self.warn("Not pushing tainted artifact.")
return False
- display_key = self._get_brief_display_key()
- with self.timed_activity("Pushing artifact {}".format(display_key)):
- # Push all keys used for local commit
- pushed = self.__artifacts.push(self, self.__get_cache_keys_for_commit())
- if not pushed:
- return False
+ # Push all keys used for local commit
+ pushed = self.__artifacts.push(self, self.__get_cache_keys_for_commit())
+ if not pushed:
+ return False
- # Notify successful upload
- self.info("Pushed artifact {}".format(display_key))
- return True
+ # Notify successful upload
+ display_key = self._get_brief_display_key()
+ self.info("Pushed artifact {}".format(display_key))
+ return True
# _shell():
#