summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Maw <jonathan.maw@codethink.co.uk>2019-04-17 17:12:50 +0100
committerbst-marge-bot <marge-bot@buildstream.build>2019-04-29 12:17:38 +0000
commite13ac6d8b8782601997d62b14e05928c5fb89fa1 (patch)
tree123d112da241d150c38d5f3ab210556accad488c
parent73ef730ed9096c6ec418176f3d903d2483262b6b (diff)
downloadbuildstream-e13ac6d8b8782601997d62b14e05928c5fb89fa1.tar.gz
element.py: _fetch_done only updates source state
-rw-r--r--buildstream/element.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/buildstream/element.py b/buildstream/element.py
index 05884c008..a4bc89691 100644
--- a/buildstream/element.py
+++ b/buildstream/element.py
@@ -1835,7 +1835,12 @@ class Element(Plugin):
def _fetch_done(self):
# We are not updating the state recursively here since fetching can
# never end up in updating them.
- self._update_state()
+
+ # Fetching changes the source state from RESOLVED to CACHED
+ # Fetching cannot change the source state from INCONSISTENT to CACHED because
+ # we prevent fetching when it's INCONSISTENT.
+ # Therefore, only the source state will change.
+ self.__update_source_state()
# _pull_pending()
#