summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Thursfield <sam.thursfield@codethink.co.uk>2017-06-30 14:56:32 +0000
committerSam Thursfield <sam.thursfield@codethink.co.uk>2017-06-30 14:58:14 +0000
commitb194179d422b65ce8eaa599901b0362840584adb (patch)
tree9fb3786d8024eb58d9fcc0e348133c4b70fca6ed
parentc5101a06fdc49d358924245b0ad4da1ec94da26d (diff)
downloadbuildstream-b194179d422b65ce8eaa599901b0362840584adb.tar.gz
element.py: Fix behaviour of Element._direct_deps(Scope.BUILD)
This function was swapping the behaviour of Scope.BUILD with Scope.ALL. This caused an issue where runtime dependencies of a component were being included in its cache key, causing unnecessary rebuilds.
-rw-r--r--buildstream/element.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/buildstream/element.py b/buildstream/element.py
index b469a9870..b987bc03e 100644
--- a/buildstream/element.py
+++ b/buildstream/element.py
@@ -581,7 +581,7 @@ class Element(Plugin):
if scope == Scope.RUN:
for element in self.__runtime_dependencies:
yield element
- elif scope != Scope.BUILD:
+ elif scope == Scope.BUILD:
for element in self.__build_dependencies:
yield element
else: