Merge branch 'bschubert/cleanup-element-fetch' into 'master'

Small cleanups in `element._fetch`

See merge request BuildStream/buildstream!1768

1 files changed, 3 insertions, 3 deletions

diff --git a/src/buildstream/element.py b/src/buildstream/element.py
index 106460b9a..ee6b90ce7 100644
--- a/src/buildstream/element.py
+++ b/src/buildstream/element.py
@@ -2096,9 +2096,9 @@ class Element(Plugin):
     #
     def _fetch(self, fetch_original=False):
         previous_sources = []
-        sources = self.__sources
         fetch_needed = False
-        if sources and not fetch_original:
+
+        if self.__sources and not fetch_original:
             for source in self.__sources:
                 if self.__sourcecache.contains(source):
                     continue
@@ -2118,7 +2118,7 @@ class Element(Plugin):
                     source._fetch(previous_sources)
                 previous_sources.append(source)
 
-        self.__cache_sources()
+            self.__cache_sources()
 
     # _calculate_cache_key():
     #