summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValentin David <valentin.david@codethink.co.uk>2018-08-14 10:21:57 +0200
committerValentin David <valentin.david@gmail.com>2018-08-14 13:31:03 +0000
commit69c5ccdeb99beecc55243ac98e2593b213cafe64 (patch)
treec718470ea55998db931d63eeaa983b70dc5e5eeb
parent9d074d7f08b7dad81a126969645701cfbd3a0807 (diff)
downloadbuildstream-69c5ccdeb99beecc55243ac98e2593b213cafe64.tar.gz
buildstream/plugins/sources/git.py: Fix clone side effect in getting fetchers
We now delay refreshing submodules until we have a clone, that is after we have fetched the main fetcher. Fixes #537
-rw-r--r--buildstream/plugins/sources/git.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/buildstream/plugins/sources/git.py b/buildstream/plugins/sources/git.py
index a7d3ad6e3..cf2f649db 100644
--- a/buildstream/plugins/sources/git.py
+++ b/buildstream/plugins/sources/git.py
@@ -414,8 +414,10 @@ class GitSource(Source):
mirror.stage(directory)
def get_source_fetchers(self):
+ yield self.mirror
self.refresh_submodules()
- return [self.mirror] + self.submodules
+ for submodule in self.submodules:
+ yield submodule
###########################################################
# Local Functions #