diff options
author | Josh Smith <qinusty@gmail.com> | 2018-09-07 16:47:01 +0100 |
---|---|---|
committer | Josh Smith <qinusty@gmail.com> | 2018-09-19 13:26:24 +0100 |
commit | 0a314bb84a7615113f73786aa1f83eb294fb0be6 (patch) | |
tree | 0f533986c16bbffe006a97cf9648ab4a7daf2722 | |
parent | 93ab82d522d92066fa94cdc74e2e4ca0d20e2377 (diff) | |
download | buildstream-0a314bb84a7615113f73786aa1f83eb294fb0be6.tar.gz |
element.py: Remove redundant timed_activity
This removes the timed_activity for an element _push action. This is
unnecessary as the job is already being timed elsewhere.
-rw-r--r-- | buildstream/element.py | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/buildstream/element.py b/buildstream/element.py index 6b0a728e6..1fefd6562 100644 --- a/buildstream/element.py +++ b/buildstream/element.py @@ -1712,16 +1712,15 @@ class Element(Plugin): self.warn("Not pushing tainted artifact.") return False - display_key = self._get_brief_display_key() - with self.timed_activity("Pushing artifact {}".format(display_key)): - # Push all keys used for local commit - pushed = self.__artifacts.push(self, self.__get_cache_keys_for_commit()) - if not pushed: - return False + # Push all keys used for local commit + pushed = self.__artifacts.push(self, self.__get_cache_keys_for_commit()) + if not pushed: + return False - # Notify successful upload - self.info("Pushed artifact {}".format(display_key)) - return True + # Notify successful upload + display_key = self._get_brief_display_key() + self.info("Pushed artifact {}".format(display_key)) + return True # _shell(): # |