diff options
| author | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-06-03 14:34:51 +0100 |
|---|---|---|
| committer | Benjamin Schubert <ben.c.schubert@gmail.com> | 2019-06-03 15:12:36 +0100 |
| commit | 49262bda8e5bc3a1886256a848618ae22229135e (patch) | |
| tree | 293e9190acf877b600f4afc17aa85fcf5af0969c /NEWS | |
| parent | 6b1f04769601328dfdd724103a4e08fc8623599c (diff) | |
| download | buildstream-49262bda8e5bc3a1886256a848618ae22229135e.tar.gz | |
_yaml.pyx: Forbid expected_type=Mapping, and remove isinstance check
Calls to `isinstance` can be particularily costly. Using type() is
much faster. The only known case where the `isinstance` was useful
is for dictionnaries where we would ask for a 'Mapping' instead.
Disallowing 'Mapping' for expected_type considerably speeds up the
calls to this functions.
Also add into NEWS
Diffstat (limited to 'NEWS')
| -rw-r--r-- | NEWS | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -2,6 +2,9 @@ buildstream 1.3.1 ================= + o BREAKING CHANGE: `node_get_member` doesn't accept 'expected_type=Mapping' + anymore. Please use 'expected_type=dict' instead. + o BREAKING CHANGE: Artifact as a Proto. The caching of buildstream artifacts has changed from a reference based impelementation. Existing artifacts and artifact servers are not compatible, as such remote artifact servers need to |