summaryrefslogtreecommitdiff
path: root/src/buildstream/_signals.py
diff options
context:
space:
mode:
authorAngelos Evripiotis <jevripiotis@bloomberg.net>2019-06-05 14:10:45 +0100
committerbst-marge-bot <marge-bot@buildstream.build>2019-06-06 14:00:14 +0000
commitf40edee612a46ab28078f218d93ea3ea0d984e52 (patch)
treedf5f37f7c27049a2d62fca9e99c1280d578f923e /src/buildstream/_signals.py
parentcdbad2be1a4943cdf0159a19a4f256bad020170c (diff)
downloadbuildstream-f40edee612a46ab28078f218d93ea3ea0d984e52.tar.gz
Rename (spawn, fork) -> 'start process'
Avoid confusion by not referring to starting another process as 'spawning'. Note that 'spawn' is a process creation method, which is an alternative to forking. Say 'create child process' instead of 'fork' where it doesn't harm understanding. Although we currently only use the 'fork' method for creating subprocesses, there are reasons for us to support 'spawn' in the future. More information on forking and spawning: https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
Diffstat (limited to 'src/buildstream/_signals.py')
-rw-r--r--src/buildstream/_signals.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/buildstream/_signals.py b/src/buildstream/_signals.py
index 41b100f93..2df2c7915 100644
--- a/src/buildstream/_signals.py
+++ b/src/buildstream/_signals.py
@@ -26,8 +26,8 @@ from collections import deque
# Global per process state for handling of sigterm/sigtstp/sigcont,
-# note that it is expected that this only ever be used by processes
-# the scheduler forks off, not the main process
+# note that it is expected that this only ever be used by new processes
+# the scheduler starts, not the main process.
terminator_stack = deque()
suspendable_stack = deque()
@@ -50,7 +50,7 @@ def terminator_handler(signal_, frame):
file=sys.stderr)
# Use special exit here, terminate immediately, recommended
- # for precisely this situation where child forks are teminated.
+ # for precisely this situation where child processes are teminated.
os._exit(-1)
@@ -125,7 +125,7 @@ def suspend_handler(sig, frame):
# suspend_callback (callable): A function to call as process suspend time.
# resume_callback (callable): A function to call as process resume time.
#
-# This must be used in code blocks which spawn processes that become
+# This must be used in code blocks which start processes that become
# their own session leader. In these cases, SIGSTOP and SIGCONT need
# to be propagated to the child process group.
#