tests: str(datafiles) instead of a longer thing

Replace some popular copypasta.

This important-looking invocation:

    os.path.join(datafiles.dirname, datafiles.basename)

is equivalent to this shorter invocation:

    project = str(datafiles)

It seems like it's very popular copypasta, replace it with the shorter
one thus:

    # Use 'gsed' or 'sed' etc. as appropriate for your system.
    git config --global alias.sub '!f() { git grep --name-only --null "$1" | gxargs --null gsed --in-place --expression "s/$1/$2/g" ; }; f'
    git sub 'os.path.join(datafiles.dirname, datafiles.basename)' 'str(datafiles)'

1 files changed, 4 insertions, 4 deletions

diff --git a/tests/internals/pluginloading.py b/tests/internals/pluginloading.py
index 675ac8540..2d997077a 100644
--- a/tests/internals/pluginloading.py
+++ b/tests/internals/pluginloading.py
@@ -32,7 +32,7 @@ def create_pipeline(tmpdir, basedir, target):
 @pytest.mark.datafiles(os.path.join(DATA_DIR, 'customsource'))
 def test_customsource(datafiles, tmpdir):
 
-    basedir = os.path.join(datafiles.dirname, datafiles.basename)
+    basedir = str(datafiles)
     targets = create_pipeline(tmpdir, basedir, 'simple.bst')
     assert targets[0].get_kind() == "autotools"
 
@@ -40,14 +40,14 @@ def test_customsource(datafiles, tmpdir):
 @pytest.mark.datafiles(os.path.join(DATA_DIR, 'customelement'))
 def test_customelement(datafiles, tmpdir):
 
-    basedir = os.path.join(datafiles.dirname, datafiles.basename)
+    basedir = str(datafiles)
     targets = create_pipeline(tmpdir, basedir, 'simple.bst')
     assert targets[0].get_kind() == "foo"
 
 
 @pytest.mark.datafiles(os.path.join(DATA_DIR, 'badversionsource'))
 def test_badversionsource(datafiles, tmpdir):
-    basedir = os.path.join(datafiles.dirname, datafiles.basename)
+    basedir = str(datafiles)
 
     with pytest.raises(LoadError) as exc:
         create_pipeline(tmpdir, basedir, 'simple.bst')
@@ -57,7 +57,7 @@ def test_badversionsource(datafiles, tmpdir):
 
 @pytest.mark.datafiles(os.path.join(DATA_DIR, 'badversionelement'))
 def test_badversionelement(datafiles, tmpdir):
-    basedir = os.path.join(datafiles.dirname, datafiles.basename)
+    basedir = str(datafiles)
 
     with pytest.raises(LoadError) as exc:
         create_pipeline(tmpdir, basedir, 'simple.bst')