summaryrefslogtreecommitdiff
path: root/buildstream/_scheduler/queues/queue.py
diff options
context:
space:
mode:
Diffstat (limited to 'buildstream/_scheduler/queues/queue.py')
-rw-r--r--buildstream/_scheduler/queues/queue.py18
1 files changed, 11 insertions, 7 deletions
diff --git a/buildstream/_scheduler/queues/queue.py b/buildstream/_scheduler/queues/queue.py
index f058663a1..0e07a078f 100644
--- a/buildstream/_scheduler/queues/queue.py
+++ b/buildstream/_scheduler/queues/queue.py
@@ -326,16 +326,20 @@ class Queue():
detail=traceback.format_exc())
self.failed_elements.append(element)
else:
-
- # No exception occured, handle the success/failure state in the normal way
#
+ # No exception occured in post processing
+ #
+
+ # All jobs get placed on the done queue for later processing.
self._done_queue.append(job)
- if success:
- if not job.skipped:
- self.processed_elements.append(element)
- else:
- self.skipped_elements.append(element)
+ # A Job can be skipped whether or not it has failed,
+ # we want to only bookkeep them as processed or failed
+ # if they are not skipped.
+ if job.skipped:
+ self.skipped_elements.append(element)
+ elif success:
+ self.processed_elements.append(element)
else:
self.failed_elements.append(element)