summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* wip: .gitlab-ci.yml: Update BuildBoxjuerg/buildboxJürg Billeter2020-11-241-1/+1
|
* tests/frontend/push.py: Skip expiry test without subsecond mtimeJürg Billeter2020-11-241-0/+10
| | | | | Skip an artifact expiry test in the case we don't have subsecond mtime precision.
* Merge branch 'tristan/fix-glob-handling' into 'master'Tristan Van Berkom2020-11-2016-69/+291
|\ | | | | | | | | | | | | Fix glob handling in the CLI Closes #959 See merge request BuildStream/buildstream!2102
| * tests/frontend/show.py: Added test for glob pattern matches.tristan/fix-glob-handlingTristan van Berkom2020-11-191-0/+46
| |
| * tests/frontend/artifact_show.py: Added tests for glob pattern matches.Tristan van Berkom2020-11-199-0/+121
| | | | | | | | | | | | This tests a few glob patterns through `bst artifact show` and also asserts that globs which match both elements and artifacts will produce an error.
| * _stream.py: Use consistent glob handling with utils.glob()Tristan van Berkom2020-11-192-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | We should not have a different globbing behavior than split rules for the command line. This should also make artifact globbing slightly more performant, as the regular expression under the hood need not be recompiled for each file being checked. This commit also updates tests/frontend/artifact_list_contents.py to use a double star `**` (globstar syntax) in order to match path separators as well as all other characters in the list contents command.
| * _stream.py: Use consistent glob handling with utils.glob()Tristan van Berkom2020-11-191-6/+3
| | | | | | | | | | | | | | | | | | | | | | Don't use fnmatch(), as this has a different behavior from utils.glob(), which is a bit closer to what we expect from a shell (* matches everything except path separators, while ** matches path separators), and also consistent with other places where BuildStream handles globbing, like when considering split rules. We should not have a different globbing behavior than split rules for the command line.
| * _stream.py: Only optionally try to glob for artifact namesTristan van Berkom2020-11-194-65/+118
|/ | | | | | | | | | | | | | | | | | | | | | | | | The patch does the following things: * Ensure that we only ever try to match artifacts to user provided glob patterns if we are performing a command which tries to load artifacts. * Stops being selective about glob patterns, if the user provides a pattern which does not end in ".bst", we still try to match it against elements. * Provide a warning when the provided globs did not match anything, previously this code only provided this warning if artifacts were not matched to globs, but not elements. * tests/frontend/artifact_delete.py, tests/frontend/push.py, tests/frontend/buildcheckout.py: Fixed tests to to not try to determine success by examining the wording of a user facing message, use the machine readable errors instead. Fixes #959
* Merge branch 'tpollard/drop_plugin_comment' into 'master'bst-marge-bot2020-11-051-2/+2
|\ | | | | | | | | src/buildstream/element.py: __use_remote_execution() reword desc See merge request BuildStream/buildstream!2097
| * src/buildstream/element.py: __use_remote_execution() reword descTom Pollard2020-11-051-2/+2
|/ | | | | Element Plugins now require the use of virtual directories as such they do not influence RE support. Reword for config hierarchy.
* Merge branch 'chandan/py39' into 'master'bst-marge-bot2020-11-044-22/+29
|\ | | | | | | | | Add test environment for Python 3.9 See merge request BuildStream/buildstream!2098
| * NEWS/setup.py: Advertise our support for Python 3.9Chandan Singh2020-11-042-0/+3
| |
| * tox.ini/.gitlab-ci.yml: Add test environment for Python 3.9Chandan Singh2020-11-042-22/+26
|/
* Merge branch 'bschubert/notify-prepare-plan' into 'master'bst-marge-bot2020-11-042-2/+10
|\ | | | | | | | | _stream.py: Make `_enqueue_plan` a timed activity See merge request BuildStream/buildstream!1840
| * _stream.py: Make `_enqueue_plan` a timed activitybschubert/notify-prepare-planBenjamin Schubert2020-11-042-2/+10
|/ | | | | | This enqueue_plan can take a long time, as it triggers a verification of the 'cached' state for sources in some cases, which can take a long time.
* Merge branch 'tristan/override-elements' into 'master'bst-marge-bot2020-11-0437-46/+456
|\ | | | | | | | | Support overrides semantic for elements See merge request BuildStream/buildstream!2094
| * plugins/elements/junction.py: Documenting element overrides.tristan/override-elementsTristan van Berkom2020-11-041-2/+76
| |
| * tests/format/junctions.py: Testing element override scenariosTristan van Berkom2020-11-0434-5/+221
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Test that we can override an element in a subproject with a local element, the local element has a dependency on another element in the subproject through the same junction. * Test that we can override the dependency in the subproject, proving that reverse dependencies in that subproject are built against the overridden element. * Test that we can override a subproject element using a local link to another element in the same subproject. * Test that we can declare an override of a subproject element using a link in that subproject, and it will be effective even if that link is not traversed by the actual dependency chain. * Check that the same element being overridden multiple times in a subproject is overridden by the highest level project which should have the highest priority in the overrides.
| * _loader/loader.py: Support overriding elementsTristan van Berkom2020-11-042-39/+159
|/ | | | | | | | | | | Using the same semantic used to override junctions in subprojects, allow overriding of elements. As discussed in this proposal: https://lists.apache.org/thread.html/r34c8e94f024aae3d5afd260554dac594e82751ca60dea28880f520d5%40%3Cdev.buildstream.apache.org%3E Notably, this also adds the "fully loaded" flag to LoadElement, and separates the logic around loading a single file with redirections for overrides and links in consideration into a single function.
* Merge branch 'chandan/py39-platform' into 'master'bst-marge-bot2020-10-291-6/+12
|\ | | | | | | | | testutils/platform: Refactor to be compatible with Python 3.9 See merge request BuildStream/buildstream!2092
| * testutils/platform: Refactor to be compatible with Python 3.9chandan/py39-platformChandan Singh2020-10-291-6/+12
|/ | | | | | | | | | | Starting from Python 3.9, it seems like the `_replace()` method no longer works on `platform.uname_result` objects, that are returned by `platform.uname()`. This causes some of our tests to fail on Python 3.9. See https://bugs.python.org/issue42163 for upstream issue. Fix it by slightly changing the way we override the values of the `platform.uname()` function, such that it works on both Python 3.9 and 3.8 (and below).
* Merge branch 'dwinship/get-release-and-snapshot-badges-from-docs-website' ↵bst-marge-bot2020-10-291-2/+2
|\ | | | | | | | | | | | | into 'master' Get release and snapshot badge images from docs website See merge request BuildStream/buildstream!2086
| * get release and snapshot badges from docs websitedwinship/get-release-and-snapshot-badges-from-docs-websiteDouglas Winship2020-10-281-2/+2
|/ | | | | | get release badge image and snapshot badge image from: docs.buildstream.build/master/_static/release.svg, and docs.buildstream.build/master/_static/snapshot.svg
* Merge branch 'tristan/loader-fixes' into 'master'bst-marge-bot2020-10-271-4/+8
|\ | | | | | | | | Corner case fixes for the loader code See merge request BuildStream/buildstream!2093
| * _loader/loader.py: Fixing new pylint "no-member" errortristan/loader-fixesTristan van Berkom2020-10-271-1/+1
| | | | | | | | | | These appear to be popping up randomly, as we squash them in our game of whackamole...
| * _loader/loader.py: Fix _load_file() for cross project link element loads.Tristan van Berkom2020-10-271-1/+5
| | | | | | | | | | | | | | When loading a link in _load_file(), we should redirect the entire call to the appropriate loader, the code in place instead was treating the loaded element as if it were loaded locally, and attempting to load it's dependencies redundantly.
| * _loader/loader.py: Avoid double dictionary lookupTristan van Berkom2020-10-271-2/+2
|/ | | | Use try / except KeyError instead.
* Merge branch 'tristan/fix-logging-element-names' into 'master'bst-marge-bot2020-10-2720-107/+315
|\ | | | | | | | | | | | | Restore task element name / element name distinction in UI Closes #1393 See merge request BuildStream/buildstream!2070
| * tests/frontend/logging.py: Test log lines for correct element names/keysTristan van Berkom2020-10-278-4/+174
| | | | | | | | | | | | | | | | | | | | | | | | When printing log lines to the master log, we ensure that log lines are printed with the element name and cache key which are related to the task from which the messages are being issued. When printing log lines to task specific log lines, we prefer to print the element names and cache keys which pertain to the element from which the log line was actually issued. This new tests asserts this behavior.
| * Restore task element name / element name distinction in UITristan van Berkom2020-10-278-40/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior has regressed a while back when introducing the messenger object in 0026e379 from merge request !1500. Main behavior change: - Messages in the master log always appear with the task element's element name and cache key, even if the element or plugin issuing the log line is not the primary task element. - Messages logged in the task specific log, retain the context of the element names and cache keys which are issuing the log lines. Changes include: * _message.py: Added the task element name & key members * _messenger.py: Log the element key as well if it is provided * _widget.py: Prefer the task name & key when logging, we fallback to the element name & key in case messages are being logged outside of any ongoing task (main process/context) * job.py: Unconditionally stamp messages with the task name & key Also removed some unused parameters here, clearing up an XXX comment * plugin.py: Add new `_message_kwargs` instance property, it is the responsibility of the core base class to maintain the base keyword arguments which are to be used as kwargs for Message() instances created on behalf of the issuing plugin. Use this method to construct messages in Plugin.__message() and to pass kwargs along to Messenger.timed_activity(). * element.py: Update the `_message_kwargs` when the cache key is updated * tests/frontend/logging.py: Fix test to expect the cache key in the logline * tests/frontend/artifact_log.py: Fix test to expect the cache key in the logline Fixes #1393
| * _messenger.py: Use kwargs in timed_activity() and simple_task()Tristan van Berkom2020-10-271-20/+19
| | | | | | | | | | This allows more flexible usage of the APIs, to allow passing all of the Message() constructor arguments through kwargs.
| * element.py: Remove Element._get_brief_display_key()Tristan van Berkom2020-10-271-14/+2
| | | | | | | | | | Now that we have _DisplayKey(), no need for this extra accessor, it's not helping anything to have it anymore.
| * _artifactcache.py: Use Element._get_display_key()Tristan van Berkom2020-10-271-9/+5
| | | | | | | | | | Instead of using Element._get_brief_display_key(), no need for that second accessor.
| * _elementsources.py: Fix copy/paste error in API doc commentTristan van Berkom2020-10-271-1/+1
| |
| * Adding _DisplayKey typeTristan van Berkom2020-10-276-22/+39
|/ | | | | | | | | | | | | | | | | | | Instead of passing around untyped tuples for cache keys, lets have a clearly typed object for this. This makes for more readable code, and additionally corrects the data model statement of intent that some cache keys should be displayed as "dim", instead informing the frontend about whether the cache key is "strict" or not, allowing the frontend to decide how to display a strict or non-strict key. This patch does the following: * types.py: Add _DisplayKey * element.py: Return a _DisplayKey from Element._get_display_key() * Other sources: Updated to use the display key object
* Merge branch 'juerg/shell' into 'master'bst-marge-bot2020-10-2734-277/+129
|\ | | | | | | | | Simplify `bst shell` implementation See merge request BuildStream/buildstream!2084
| * NEWS: Add note about the `bst shell --use-buildtree` changejuerg/shellJürg Billeter2020-10-271-0/+7
| |
| * Regenerate man pagesJürg Billeter2020-10-2725-27/+27
| |
| * _frontend/cli.py: Drop support for bst shell --use-buildtree=tryJürg Billeter2020-10-276-107/+29
| | | | | | | | | | `--use-buildtree` is now a boolean option for `bst shell`. If no buildtree is available, an error is raised.
| * _stream.py: Simplify code in shell()Jürg Billeter2020-10-272-102/+38
| | | | | | | | | | | | Use single scheduler run for pulling dependencies and buildtree. Deduplicate cache checks and corresponding warning/error messages with and without pulling enabled.
| * element.py: Add optional scope parameter to _set_required()Jürg Billeter2020-10-271-5/+8
| |
| * Move shell element loading logic from Cli to StreamJürg Billeter2020-10-273-69/+73
| |
| * _stream.py: Use callback for shell promptJürg Billeter2020-10-273-14/+15
| |
| * _frontend/cli.py: Make bst shell --use-buildtree imply --buildJürg Billeter2020-10-271-0/+4
| |
| * _frontend/cli.py: Drop support for bst shell --use-buildtree=askJürg Billeter2020-10-271-27/+2
|/
* Merge branch 'bschubert/simplify-workspace-test' into 'master'bst-marge-bot2020-10-261-105/+25
|\ | | | | | | | | Simplify source workspace tests See merge request BuildStream/buildstream!2085
| * workspace.py: Don't use the same directory for everythingbschubert/simplify-workspace-testBenjamin Schubert2020-10-261-6/+3
| |
| * workspace.py: Simplify invocation of the cli commandBenjamin Schubert2020-10-261-5/+1
| |
| * workspace.py: Remove some abstractions and write the whole test in placeBenjamin Schubert2020-10-261-46/+31
| | | | | | | | | | | | This is to remove some hoops that are currently used, that do not fit well with most of the style in the code. It also removes indirections and make the test easier to understand
| * workspace.py: Remove arguments that are unused during the testBenjamin Schubert2020-10-261-31/+15
| |