<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bundler.git, branch catch_up_with_rubygems_plugin_loading_changes</title>
<subtitle>github.com: bundler/bundler.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/'/>
<entry>
<title>Try self</title>
<updated>2020-02-21T17:36:10+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2020-02-21T17:36:10+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=e11eace4e0213ced7c505080ce168f5470459c84'/>
<id>e11eace4e0213ced7c505080ce168f5470459c84</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Make sure rubygems plugin loading works as intended in a bundler context</title>
<updated>2020-02-21T17:33:03+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2020-02-21T09:51:09+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=d7fdf66183115d47bb98fdb1ce6e2acc14b56483'/>
<id>d7fdf66183115d47bb98fdb1ce6e2acc14b56483</id>
<content type='text'>
In a `bundler/setup` context, we only want to load the plugins for gems
present in the $LOAD_PATH. In that context, `Gem.load_env_plugins` does
the trick just fine.

We don't want any of the globally installed gems to load anything an
"pollute" this environment so we stub `Gem.load_plugins` as a no-op.

There was some `Bundler::Installer` code though using
`Gem.load_plugins`. I'm not really sure about the usefulness of that
code, but since it's not the point of this PR to question it, I rewrite
it to avoid using `Gem.load_plugins`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In a `bundler/setup` context, we only want to load the plugins for gems
present in the $LOAD_PATH. In that context, `Gem.load_env_plugins` does
the trick just fine.

We don't want any of the globally installed gems to load anything an
"pollute" this environment so we stub `Gem.load_plugins` as a no-op.

There was some `Bundler::Installer` code though using
`Gem.load_plugins`. I'm not really sure about the usefulness of that
code, but since it's not the point of this PR to question it, I rewrite
it to avoid using `Gem.load_plugins`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Extract finding the `Gem` singleton class to a method</title>
<updated>2020-02-21T09:27:29+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2020-02-21T09:27:29+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=9eece07273c6550b6eae1c8dc508c012917d0cf4'/>
<id>9eece07273c6550b6eae1c8dc508c012917d0cf4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7649</title>
<updated>2020-02-20T20:17:56+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2020-02-20T20:17:56+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=447cdd69004239a850fc12225ce2a47e3c473d39'/>
<id>447cdd69004239a850fc12225ce2a47e3c473d39</id>
<content type='text'>
7649: Fix resolving specs when run against a dev ruby snapshot r=deivid-rodriguez a=deivid-rodriguez


&lt;!--
Thanks so much for the contribution!

If you're updating documentation, make sure you run `bin/rake man:build` and
squash the result into your changes, so that all documentation formats are
updated.

To make reviewing this PR a bit easier, please fill out answers to the following questions.
--&gt;

### What was the end-user or developer problem that led to this PR?

The problem is that in some dev ruby builds, `RUBY_PATCHLEVEL` is `-1`, so the spec crashes because of an ill-formed requirement.

See for example https://github.com/rubygems/rubygems/pull/3077/checks?check_run_id=457988784.

&lt;!-- Write a clear and complete description of the problem --&gt;

### What is your fix for the problem, implemented in this PR?

&lt;!-- Explain the fix being implemented. Include any diagnosis you run to
determine the cause of the issue and your conclusions. If you considered other
alternatives, explain why you end up choosing the current implementation --&gt;

My fix is to change the spec to respect a `RUBY_PATCHLEVEL` equal to `-1`, by reusing code that handles that case.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7649: Fix resolving specs when run against a dev ruby snapshot r=deivid-rodriguez a=deivid-rodriguez


&lt;!--
Thanks so much for the contribution!

If you're updating documentation, make sure you run `bin/rake man:build` and
squash the result into your changes, so that all documentation formats are
updated.

To make reviewing this PR a bit easier, please fill out answers to the following questions.
--&gt;

### What was the end-user or developer problem that led to this PR?

The problem is that in some dev ruby builds, `RUBY_PATCHLEVEL` is `-1`, so the spec crashes because of an ill-formed requirement.

See for example https://github.com/rubygems/rubygems/pull/3077/checks?check_run_id=457988784.

&lt;!-- Write a clear and complete description of the problem --&gt;

### What is your fix for the problem, implemented in this PR?

&lt;!-- Explain the fix being implemented. Include any diagnosis you run to
determine the cause of the issue and your conclusions. If you considered other
alternatives, explain why you end up choosing the current implementation --&gt;

My fix is to change the spec to respect a `RUBY_PATCHLEVEL` equal to `-1`, by reusing code that handles that case.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix resolving specs when run against a dev ruby snapshot</title>
<updated>2020-02-20T17:16:16+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2020-02-20T17:16:16+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=61bc8fda26836e270f191f776a0a6d5575626a0c'/>
<id>61bc8fda26836e270f191f776a0a6d5575626a0c</id>
<content type='text'>
In some dev builds, `RUBY_PATCHLEVEL` is `-1`, so the spec crashes
because of an ill-formed requirement.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In some dev builds, `RUBY_PATCHLEVEL` is `-1`, so the spec crashes
because of an ill-formed requirement.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7644</title>
<updated>2020-02-20T07:38:24+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2020-02-20T07:38:24+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=860f8665f0211d22328a12c9e5ac8dcefbcbe0f0'/>
<id>860f8665f0211d22328a12c9e5ac8dcefbcbe0f0</id>
<content type='text'>
7644: Unfreeze dependency hashes r=deivid-rodriguez a=deivid-rodriguez



&lt;!--
Thanks so much for the contribution!

If you're updating documentation, make sure you run `bin/rake man:build` and
squash the result into your changes, so that all documentation formats are
updated.

To make reviewing this PR a bit easier, please fill out answers to the following questions.
--&gt;

### What was the end-user or developer problem that led to this PR?

&lt;!-- Write a clear and complete description of the problem --&gt;

Running `bin/rake spec:deps` from jruby crashes with:

```
rake aborted!
FrozenError: can't modify frozen Hash
/path/to/bundler/spec/support/rubygems_ext.rb:36:in `dev_setup'
/path/to/bundler/Rakefile:29:in `block in &lt;main&gt;'
/path/to/bundler/Rakefile:14:in `block in invoke'
/path/to/bundler/Rakefile:13:in `invoke'
/path/to/bundler/spec/support/rubygems_ext.rb:98:in `gem_load_and_activate'
/path/to/bundler/spec/support/rubygems_ext.rb:45:in `gem_load'
Tasks: TOP =&gt; spec:deps
(See full trace by running task with --trace)
```

### What is your fix for the problem, implemented in this PR?

&lt;!-- Explain the fix being implemented. Include any diagnosis you run to
determine the cause of the issue and your conclusions. If you considered other
alternatives, explain why you end up choosing the current implementation --&gt;

Unfreeze the hashes, since we are modifying them.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7644: Unfreeze dependency hashes r=deivid-rodriguez a=deivid-rodriguez



&lt;!--
Thanks so much for the contribution!

If you're updating documentation, make sure you run `bin/rake man:build` and
squash the result into your changes, so that all documentation formats are
updated.

To make reviewing this PR a bit easier, please fill out answers to the following questions.
--&gt;

### What was the end-user or developer problem that led to this PR?

&lt;!-- Write a clear and complete description of the problem --&gt;

Running `bin/rake spec:deps` from jruby crashes with:

```
rake aborted!
FrozenError: can't modify frozen Hash
/path/to/bundler/spec/support/rubygems_ext.rb:36:in `dev_setup'
/path/to/bundler/Rakefile:29:in `block in &lt;main&gt;'
/path/to/bundler/Rakefile:14:in `block in invoke'
/path/to/bundler/Rakefile:13:in `invoke'
/path/to/bundler/spec/support/rubygems_ext.rb:98:in `gem_load_and_activate'
/path/to/bundler/spec/support/rubygems_ext.rb:45:in `gem_load'
Tasks: TOP =&gt; spec:deps
(See full trace by running task with --trace)
```

### What is your fix for the problem, implemented in this PR?

&lt;!-- Explain the fix being implemented. Include any diagnosis you run to
determine the cause of the issue and your conclusions. If you considered other
alternatives, explain why you end up choosing the current implementation --&gt;

Unfreeze the hashes, since we are modifying them.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Unfreeze dep hashes</title>
<updated>2020-02-19T22:05:17+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2020-02-18T18:20:45+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=47c569dac65249f5a08605dfa8e1ddaceb32d871'/>
<id>47c569dac65249f5a08605dfa8e1ddaceb32d871</id>
<content type='text'>
These hashes are actually modified. For example, to exclude some
dependencies under jruby.

So they should not be frozen.

Without this, running `bin/rake spec:deps` from jruby crashes with:

```
rake aborted!
FrozenError: can't modify frozen Hash
/path/to/bundler/spec/support/rubygems_ext.rb:36:in `dev_setup'
/path/to/bundler/Rakefile:29:in `block in &lt;main&gt;'
/path/to/bundler/Rakefile:14:in `block in invoke'
/path/to/bundler/Rakefile:13:in `invoke'
/path/to/bundler/spec/support/rubygems_ext.rb:98:in `gem_load_and_activate'
/path/to/bundler/spec/support/rubygems_ext.rb:45:in `gem_load'
Tasks: TOP =&gt; spec:deps
(See full trace by running task with --trace)
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These hashes are actually modified. For example, to exclude some
dependencies under jruby.

So they should not be frozen.

Without this, running `bin/rake spec:deps` from jruby crashes with:

```
rake aborted!
FrozenError: can't modify frozen Hash
/path/to/bundler/spec/support/rubygems_ext.rb:36:in `dev_setup'
/path/to/bundler/Rakefile:29:in `block in &lt;main&gt;'
/path/to/bundler/Rakefile:14:in `block in invoke'
/path/to/bundler/Rakefile:13:in `invoke'
/path/to/bundler/spec/support/rubygems_ext.rb:98:in `gem_load_and_activate'
/path/to/bundler/spec/support/rubygems_ext.rb:45:in `gem_load'
Tasks: TOP =&gt; spec:deps
(See full trace by running task with --trace)
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7646</title>
<updated>2020-02-19T20:37:59+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2020-02-19T20:37:59+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=e9a4dbb494df7c5043a7db9d2880812f9c4e5618'/>
<id>e9a4dbb494df7c5043a7db9d2880812f9c4e5618</id>
<content type='text'>
7646: Pin jruby-jars in warbler test r=deivid-rodriguez a=deivid-rodriguez



&lt;!--
Thanks so much for the contribution!

If you're updating documentation, make sure you run `bin/rake man:build` and
squash the result into your changes, so that all documentation formats are
updated.

To make reviewing this PR a bit easier, please fill out answers to the following questions.
--&gt;

### What was the end-user or developer problem that led to this PR?

&lt;!-- Write a clear and complete description of the problem --&gt;

The problem is that our CI is broken after the jruby-9.2.10.0 release.

### What is your fix for the problem, implemented in this PR?

My workaround is to pin the jruby-jars dependency of the warbler test to 9.2.9.0.

&lt;!-- Explain the fix being implemented. Include any diagnosis you run to
determine the cause of the issue and your conclusions. If you considered other
alternatives, explain why you end up choosing the current implementation --&gt;

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7646: Pin jruby-jars in warbler test r=deivid-rodriguez a=deivid-rodriguez



&lt;!--
Thanks so much for the contribution!

If you're updating documentation, make sure you run `bin/rake man:build` and
squash the result into your changes, so that all documentation formats are
updated.

To make reviewing this PR a bit easier, please fill out answers to the following questions.
--&gt;

### What was the end-user or developer problem that led to this PR?

&lt;!-- Write a clear and complete description of the problem --&gt;

The problem is that our CI is broken after the jruby-9.2.10.0 release.

### What is your fix for the problem, implemented in this PR?

My workaround is to pin the jruby-jars dependency of the warbler test to 9.2.9.0.

&lt;!-- Explain the fix being implemented. Include any diagnosis you run to
determine the cause of the issue and your conclusions. If you considered other
alternatives, explain why you end up choosing the current implementation --&gt;

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Pin jruby-jars in warbler test</title>
<updated>2020-02-19T18:30:16+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2020-02-19T09:52:58+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=a60eadc4f6620148a29743b8cb00dafde5333c49'/>
<id>a60eadc4f6620148a29743b8cb00dafde5333c49</id>
<content type='text'>
It no longer works with jruby-jars 9.2.10.0.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It no longer works with jruby-jars 9.2.10.0.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7635</title>
<updated>2020-02-17T21:01:32+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2020-02-17T21:01:32+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bundler.git/commit/?id=c65280dd3f52b4b551bb3bb1ca6ab114d6a4af5c'/>
<id>c65280dd3f52b4b551bb3bb1ca6ab114d6a4af5c</id>
<content type='text'>
7635: Update code of conduct template to CC2.0 r=colby-swandale a=CoralineAda

### What was the end-user or developer problem that led to this PR?
The Contributor Covenant was updated to version 2.0 last year, but bundler was still using the old version.

### What is your fix for the problem, implemented in this PR?
I updated the `.md.tt` file containing the template, careful to preserve the interpolation of the email address.

Co-authored-by: Coraline Ada Ehmke &lt;coraline@idolhands.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7635: Update code of conduct template to CC2.0 r=colby-swandale a=CoralineAda

### What was the end-user or developer problem that led to this PR?
The Contributor Covenant was updated to version 2.0 last year, but bundler was still using the old version.

### What is your fix for the problem, implemented in this PR?
I updated the `.md.tt` file containing the template, careful to preserve the interpolation of the email address.

Co-authored-by: Coraline Ada Ehmke &lt;coraline@idolhands.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
