delta/bundler.git, branch missing_mock github.com: bundler/bundler.git Add missing mock 2019-07-04T18:44:29+00:00 David Rodríguez deivid.rodriguez@riseup.net 2018-09-05T22:08:46+00:00 3e350089db0f4f5d103e0835a9030bc255656cfc I'm not sure this test is useful but since it's there, it should be complete. 
I'm not sure this test is useful but since it's there, it should be
complete.
Merge #7229 2019-07-04T14:16:24+00:00 Bundlerbot bot@bundler.io 2019-07-04T14:16:24+00:00 566cce0629a0f1a4d147195a34d494306269e1cf 7229: Correct default cache path r=deivid-rodriguez a=Confusion The default path where `bundle package` puts the gems is `vendor/cache`, not `vendor/bundle`. Co-authored-by: Ivo Wever <ivo.wever@gmail.com> 
7229: Correct default cache path r=deivid-rodriguez a=Confusion

The default path where `bundle package` puts the gems is `vendor/cache`, not `vendor/bundle`.

Co-authored-by: Ivo Wever <ivo.wever@gmail.com>
Correct default cache path 2019-07-03T09:33:42+00:00 Ivo Wever ivo.wever@gmail.com 2019-07-03T09:33:42+00:00 49256bb3d22a329fef76b53928b2f84b89bba150 The default cache path is `vendor/cache`, not `vendor/bundle`. 
The default cache path is `vendor/cache`, not `vendor/bundle`.
 Merge #7223 2019-06-27T09:39:41+00:00 Bundlerbot bot@bundler.io 2019-06-27T09:39:41+00:00 391b11966efb140a9ba204ca4e05ec7694296ce0 7223: RUBY_ENGINE should always be defined after 1.8.7 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we have code checking that `RUBY_ENGINE` everytime it's used and I think it's unnecessary. ### What was your diagnosis of the problem? My diagnosis was that every ruby implementation newer than 1.8 should define this. ### What is your fix for the problem, implemented in this PR? My fix is to remove the unnecessary code. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> 
7223: RUBY_ENGINE should always be defined after 1.8.7 r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that we have code checking that `RUBY_ENGINE` everytime it's used and I think it's unnecessary.

### What was your diagnosis of the problem?

My diagnosis was that every ruby implementation newer than 1.8 should define this.

### What is your fix for the problem, implemented in this PR?

My fix is to remove the unnecessary code.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Merge #7221 2019-06-26T23:39:15+00:00 Bundlerbot bot@bundler.io 2019-06-26T23:39:15+00:00 3b10d9714702edcba290c967671a0e201f594938 7221: Bump rubygems in CI to 3.0.4 and 2.7.10 r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we should make sure everything is ok with the most recent rubygems releases. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade the rubygems versions in our CI. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> 
7221: Bump rubygems in CI to 3.0.4 and 2.7.10 r=hsbt a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that we should make sure everything is ok with the most recent rubygems releases.

### What is your fix for the problem, implemented in this PR?

My fix is to upgrade the rubygems versions in our CI.


Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
RUBY_ENGINE should always be defined after 1.8.7 2019-06-26T16:02:07+00:00 David Rodríguez deivid.rodriguez@riseup.net 2019-04-12T17:05:26+00:00 d6c9196d184366694fafb4fedfd72ec375bebaf8 






Bump rubygems in CI to 3.0.4 and 2.7.10
2019-06-26T15:22:25+00:00

David Rodríguez
deivid.rodriguez@riseup.net

2019-06-26T15:22:25+00:00

2ec27ac5e0363b818bd27562cc593674b9dc6011












Merge #7209
2019-06-24T11:11:13+00:00

Bundlerbot
bot@bundler.io

2019-06-24T11:11:13+00:00

547975644e93d1c421a468ab5e2396b5b953158b

7209: Add a minimum ruby version to the generated gemspec  r=hsbt a=deivid-rodriguez

This PR is a finished version of #4397.

### What was the end-user problem that led to this PR?

The problem was that the generated gemspec for new gems does not impose a minimum ruby version.

### What is your fix for the problem, implemented in this PR?

My fix is to set the minimum ruby version in the generated gemspec to the minimum ruby version supported by bundler itself.

### Why did you choose this fix out of the possible options?

I chose this fix because it's simple.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Co-authored-by: Miklos Fazekas <mfazekas@szemafor.com>





7209: Add a minimum ruby version to the generated gemspec  r=hsbt a=deivid-rodriguez

This PR is a finished version of #4397.

### What was the end-user problem that led to this PR?

The problem was that the generated gemspec for new gems does not impose a minimum ruby version.

### What is your fix for the problem, implemented in this PR?

My fix is to set the minimum ruby version in the generated gemspec to the minimum ruby version supported by bundler itself.

### Why did you choose this fix out of the possible options?

I chose this fix because it's simple.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Co-authored-by: Miklos Fazekas <mfazekas@szemafor.com>







Merge #7161
2019-06-24T10:33:28+00:00

Bundlerbot
bot@bundler.io

2019-06-24T10:33:28+00:00

c5dcdfbc3617d1ecf551f047456d4ea03a18f930

7161: Fix file URIs on Windows r=hsbt a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that file:// URIs were not properly handled on Windows, and those are heavily used by our specs.

### What was your diagnosis of the problem?

My diagnosis was that Windows paths do not start with a slash, so we need to add an extra slash to
separate the host from the path in file:// urls. Otherwise "D:" is parsed as the host segment in the URI.

As a consequence of that change, we also need to strip that leading character when using the path segment for those URIs, so that it's a valid file path on Windows.

This change reduces Windows CI spec failures from 429 to 355.

In order to apply this fix for all file URI's in tests, I extracted a helper method and searched and replaced all file:// ocurrences with the method. The diff is big because of that, but I think it works fine.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>





7161: Fix file URIs on Windows r=hsbt a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that file:// URIs were not properly handled on Windows, and those are heavily used by our specs.

### What was your diagnosis of the problem?

My diagnosis was that Windows paths do not start with a slash, so we need to add an extra slash to
separate the host from the path in file:// urls. Otherwise "D:" is parsed as the host segment in the URI.

As a consequence of that change, we also need to strip that leading character when using the path segment for those URIs, so that it's a valid file path on Windows.

This change reduces Windows CI spec failures from 429 to 355.

In order to apply this fix for all file URI's in tests, I extracted a helper method and searched and replaced all file:// ocurrences with the method. The diff is big because of that, but I think it works fine.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>







Merge #7216
2019-06-24T04:44:51+00:00

Bundlerbot
bot@bundler.io

2019-06-24T04:44:51+00:00

67bd477a2831e476c682ad41878ee99248420c07

7216: Revert "Migrate requires from exe/ to also be relative" r=hsbt a=deivid-rodriguez


### What was the end-user problem that led to this PR?

The problem was that in https://github.com/bundler/bundler/pull/7193, I included [a commit](https://github.com/bundler/bundler/pull/7193/commits/d9d2bf6d522dd36d1ef2732e87cef8b7cba729fd) to migrate requires included in bundler's executable to use `require_relative`. That broke stuff.

### What was your diagnosis of the problem?

My diagnosis was the assumption that if `<install_folder>/exe/bundle` lives on a folder, the corresponding bundler lib lives on `<install_folder>/lib` doesn't hold for default gems. Default gems for gems with executables live in `site_lib` but install their executables in the standard gem location. That means that the reference commit breaks bundler when it is installed as a default gem.

### What is your fix for the problem, implemented in this PR?

My fix is to revert the commit.

### Why did you choose this fix out of the possible options?

I chose this fix because it's the easiest way. The proper long term fix is probably to make default gems behave in a more standard way. There's some ongoing work on that here: https://github.com/rubygems/rubygems/pull/2166.


Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>





7216: Revert "Migrate requires from exe/ to also be relative" r=hsbt a=deivid-rodriguez


### What was the end-user problem that led to this PR?

The problem was that in https://github.com/bundler/bundler/pull/7193, I included [a commit](https://github.com/bundler/bundler/pull/7193/commits/d9d2bf6d522dd36d1ef2732e87cef8b7cba729fd) to migrate requires included in bundler's executable to use `require_relative`. That broke stuff.

### What was your diagnosis of the problem?

My diagnosis was the assumption that if `<install_folder>/exe/bundle` lives on a folder, the corresponding bundler lib lives on `<install_folder>/lib` doesn't hold for default gems. Default gems for gems with executables live in `site_lib` but install their executables in the standard gem location. That means that the reference commit breaks bundler when it is installed as a default gem.

### What is your fix for the problem, implemented in this PR?

My fix is to revert the commit.

### Why did you choose this fix out of the possible options?

I chose this fix because it's the easiest way. The proper long term fix is probably to make default gems behave in a more standard way. There's some ongoing work on that here: https://github.com/rubygems/rubygems/pull/2166.


Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>