delta/bundler.git, branch update-deprecated-methods github.com: bundler/bundler.git Use Gem::Util.inflate instead of Gem.inflate 2018-03-01T03:38:43+00:00 SHIBATA Hiroshi hsbt@ruby-lang.org 2018-03-01T03:38:43+00:00 9448fc8c37eb9f867f352c3085f20994c7726fa9 






Auto merge of #6306 - alyssais:gpg_test, r=colby-swandale
2018-02-23T22:13:10+00:00

The Bundler Bot
bot@bundler.io

2018-02-23T22:13:10+00:00

c4fc79a2bfed38335a3371300bea49286a371d83

Don't GPG-sign test setup commits

Running `bin/rake spec` in the Bundler repository causes a bunch of failures if `commit.gpgsign` is set in the global Git configuration.

Bundler's tests were making Git commits and trying to GPG sign them.

Set `commit.gpgsign` to `false` when initializing a Git repository in the tests.

I chose this fix because the alternative would be to pass `--no-gpg-sign` every time a commit is made in the tests, which would have a bigger maintenance impact.





Don't GPG-sign test setup commits

Running `bin/rake spec` in the Bundler repository causes a bunch of failures if `commit.gpgsign` is set in the global Git configuration.

Bundler's tests were making Git commits and trying to GPG sign them.

Set `commit.gpgsign` to `false` when initializing a Git repository in the tests.

I chose this fix because the alternative would be to pass `--no-gpg-sign` every time a commit is made in the tests, which would have a bigger maintenance impact.







Don't GPG-sign test setup commits
2018-02-23T09:45:36+00:00

Alyssa Ross
hi@alyssa.is

2018-02-22T11:54:57+00:00

9f3bad4e352bc35352d91008182173ab50ecbca2

This is extremely inconvenient (or sometimes plain broken) when the
person running the tests has `commit.gpgsign` enabled in their global
Git configuration.





This is extremely inconvenient (or sometimes plain broken) when the
person running the tests has `commit.gpgsign` enabled in their global
Git configuration.







Auto merge of #6304 - deivid-rodriguez:fix/new_gem_generation_crash, r=colby-swandale
2018-02-22T20:55:29+00:00

The Bundler Bot
bot@bundler.io

2018-02-22T20:55:29+00:00

3d8258586b0fab8899d9a6f801d301e8db4d3ba6

Fix `bundle gem` generating unparsable ruby

### What was the end-user problem that led to this PR?

The problem was that the main file in a gem generated by `bundle gem` can't be inspected via `rubocop`.

### What was your diagnosis of the problem?

My diagnosis was `bundler` was generating unparsable ruby in the generated gem.

### What is your fix for the problem, implemented in this PR?

My fix was to change the offending template to generate valid ruby code.

### Why did you choose this fix out of the possible options?

I chose this fix because it's the only one, really.





Fix `bundle gem` generating unparsable ruby

### What was the end-user problem that led to this PR?

The problem was that the main file in a gem generated by `bundle gem` can't be inspected via `rubocop`.

### What was your diagnosis of the problem?

My diagnosis was `bundler` was generating unparsable ruby in the generated gem.

### What is your fix for the problem, implemented in this PR?

My fix was to change the offending template to generate valid ruby code.

### Why did you choose this fix out of the possible options?

I chose this fix because it's the only one, really.







Fix unparsable ruby generated by `bundle gem`
2018-02-22T13:35:12+00:00

David Rodríguez
deivid.rodriguez@riseup.net

2018-02-22T13:29:18+00:00

9a8328395ad05607267e190181845a4f10db31e4

Introduced in https://github.com/bundler/bundler/pull/6267.





Introduced in https://github.com/bundler/bundler/pull/6267.







Auto merge of #6300 - cpgo:remove-add-timestamp-comment, r=colby-swandale
2018-02-20T12:29:08+00:00

The Bundler Bot
bot@bundler.io

2018-02-20T12:29:08+00:00

86e4b2a636fa2153bcd048dc084ace180cfe5c4a

Remove comment with timestamp on `bundle add`

As discussed on #6193 this PR simply removes the comment timestamp when adding a gem via command line.





Remove comment with timestamp on `bundle add`

As discussed on #6193 this PR simply removes the comment timestamp when adding a gem via command line.







remove timestamp comment
2018-02-20T01:44:02+00:00

Cassio Godinho
cassiopgodinho@gmail.com

2018-02-20T01:44:02+00:00

c518c36319bd2dd281623283c026dca3216b02cd












Auto merge of #6184 - arbonap:pa-check-in-gemfile-docs, r=indirect
2018-02-13T01:45:35+00:00

The Bundler Bot
bot@bundler.io

2018-02-13T01:45:35+00:00

30f7b45e2414eb82e1dcc592a4dd5146438f4a63

Update docs to reflect revised guidance to check in locks for gems

Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.

### What was the end-user problem that led to this PR?

The problem was...
- Bundler stopped gitignoring gem locks. The change was merged in but we need to reflect that change in documentation.
### What was your diagnosis of the problem?

My diagnosis was...
- To add in documentation explaining why Bunder now does _not_ gitignore gem locks.
### What is your fix for the problem, implemented in this PR?

My fix...
- Update the `gemfile.lock` section of `bundle install` man pages as well as the `gemfile` man page.
### Why did you choose this fix out of the possible options?

I chose this fix because...
- This addresses open issue https://github.com/bundler/bundler/issues/5879





Update docs to reflect revised guidance to check in locks for gems

Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.

### What was the end-user problem that led to this PR?

The problem was...
- Bundler stopped gitignoring gem locks. The change was merged in but we need to reflect that change in documentation.
### What was your diagnosis of the problem?

My diagnosis was...
- To add in documentation explaining why Bunder now does _not_ gitignore gem locks.
### What is your fix for the problem, implemented in this PR?

My fix...
- Update the `gemfile.lock` section of `bundle install` man pages as well as the `gemfile` man page.
### Why did you choose this fix out of the possible options?

I chose this fix because...
- This addresses open issue https://github.com/bundler/bundler/issues/5879







Tweak language, remove lock info from Gemfile doc.
2018-02-13T01:35:33+00:00

Andre Arko
andre@arko.net

2018-02-13T01:35:33+00:00

da6e69224705406698d01cff54bdd9ca18278a4c

After reviewing, I think the question and answer is a bad fit for the
`gemfile` man page. It does seem like a good fit for the FAQ page on the
Bundler documentation site, though, and I'll add it over there.





After reviewing, I think the question and answer is a bad fit for the
`gemfile` man page. It does seem like a good fit for the FAQ page on the
Bundler documentation site, though, and I'll add it over there.







Auto merge of #6283 - bundler:indirect/add-coc-enforcement, r=indirect
2018-02-08T18:22:13+00:00

The Bundler Bot
bot@bundler.io

2018-02-08T18:22:13+00:00

79d6e4f6c55704b7c715fc99a102048a6d030545

Add enforcement steps and examples to the CoC.

package.community has done a terrific job with their clear explanation
of what enforcing a CoC looks like. Bundler is a better place when
everyone knows what kind of behavior is expected, and what will happen
if those expectations are not met, for whatever reason.





Add enforcement steps and examples to the CoC.

package.community has done a terrific job with their clear explanation
of what enforcing a CoC looks like. Bundler is a better place when
everyone knows what kind of behavior is expected, and what will happen
if those expectations are not met, for whatever reason.