diff options
| author | Bundlerbot <bot@bundler.io> | 2018-10-30 01:44:34 +0000 |
|---|---|---|
| committer | Bundlerbot <bot@bundler.io> | 2018-10-30 01:44:34 +0000 |
| commit | 70f2afe1cfadfe888d6bd1100fac6672dd7baab6 (patch) | |
| tree | 628c63a289e3100dcf97c2a86cb3acb5f8c51f82 /.github/bors.toml | |
| parent | 42a32302ea53fec35d6f7911315de870343eb722 (diff) | |
| parent | f20939e4b303640d05d1c2204d3e030c7ce9d5e3 (diff) | |
| download | bundler-70f2afe1cfadfe888d6bd1100fac6672dd7baab6.tar.gz | |
Merge #6769
6769: Fix `remove` when block method appears in gem name r=segiddins a=dduugg
Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.
### What was the end-user problem that led to this PR?
https://github.com/bundler/bundler/issues/6768
### What was your diagnosis of the problem?
`remove_nested_blocks` considers any appearance of text matching a block method (`group source env install_if`) to be an occurrence of a nested block.
### What is your fix for the problem, implemented in this PR?
`remove_nested_blocks` should only reduce the scope of where a nested block method can occur.
### Why did you choose this fix out of the possible options?
Another approach would use word delimiters rather than `starts_with?` to find nested block methods, but this is probably fine.
Co-authored-by: Douglas Eichelberger <dduugg@gmail.com>
Diffstat (limited to '.github/bors.toml')
0 files changed, 0 insertions, 0 deletions