diff options
| author | The Bundler Bot <bot@bundler.io> | 2018-06-26 13:38:20 +0000 |
|---|---|---|
| committer | Colby Swandale <hello@colby.fyi> | 2018-07-10 23:02:45 +1000 |
| commit | 45e9e635b496deec80b7cc6fa3d67b2c43f27475 (patch) | |
| tree | 933f3f797b5ad92c639c7e423735fdfce6672249 | |
| parent | 920f0e2e511c14ea62a07cba3a20ec541ad4d9b5 (diff) | |
| download | bundler-45e9e635b496deec80b7cc6fa3d67b2c43f27475.tar.gz | |
Auto merge of #6601 - deivid-rodriguez:more_flexible_stub, r=segiddins
More flexible stub
### What was the end-user problem that led to this PR?
My problem is that I can't get https://github.com/rubygems/rubygems/pull/2332 CI passing.
### What was your diagnosis of the problem?
My diagnosis was that current bundler test don't support my changes in that PR, because previously the `validate` method in `rubygems` would be called without arguments, and now it's called with two arguments.
### What is your fix for the problem, implemented in this PR?
My fix is to make the specification stub more flexible so it supports any number of arguments.
### Why did you choose this fix out of the possible options?
I chose this fix because it supports my changes and doesn't break the previous version either.
(cherry picked from commit b8fdc4ae2318369a7cd71eabcdc611162fa2fee6)
| -rw-r--r-- | spec/support/builders.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/support/builders.rb b/spec/support/builders.rb index a90260a80e..64c3f5cc7b 100644 --- a/spec/support/builders.rb +++ b/spec/support/builders.rb @@ -600,7 +600,7 @@ module Spec @spec.rubygems_version = options[:rubygems_version] def @spec.mark_version; end - def @spec.validate; end + def @spec.validate(*); end end case options[:gemspec] |