diff options
| author | Samuel E. Giddins <segiddins@segiddins.me> | 2015-07-15 20:47:15 -0700 |
|---|---|---|
| committer | Samuel E. Giddins <segiddins@segiddins.me> | 2015-07-15 20:47:15 -0700 |
| commit | 4dd3e73459545c4a94913fe465e37b2da0c710b1 (patch) | |
| tree | 6b600ddfb72c59f71c61da4ff2047c0ba29d7dc4 | |
| parent | 53b10b279e8d81186198e90665666d40c6ec292e (diff) | |
| download | bundler-4dd3e73459545c4a94913fe465e37b2da0c710b1.tar.gz | |
[RuboCop] Enable Lint/LiteralInCondition
| -rw-r--r-- | .rubocop_todo.yml | 4 | ||||
| -rw-r--r-- | lib/bundler/graph.rb | 2 | ||||
| -rw-r--r-- | spec/support/ruby_ext.rb | 2 |
3 files changed, 2 insertions, 6 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 26a51aff2f..fc1336bfe1 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -13,10 +13,6 @@ Lint/Eval: Lint/HandleExceptions: Enabled: false -# Offense count: 2 -Lint/LiteralInCondition: - Enabled: false - # Offense count: 1 Lint/Loop: Enabled: false diff --git a/lib/bundler/graph.rb b/lib/bundler/graph.rb index fbb5bd0248..244e3e9b99 100644 --- a/lib/bundler/graph.rb +++ b/lib/bundler/graph.rb @@ -30,7 +30,7 @@ module Bundler def _populate_relations parent_dependencies = _groups.values.to_set.flatten - while true + loop do if parent_dependencies.empty? break else diff --git a/spec/support/ruby_ext.rb b/spec/support/ruby_ext.rb index f1590a73bc..b70fb7bf82 100644 --- a/spec/support/ruby_ext.rb +++ b/spec/support/ruby_ext.rb @@ -5,7 +5,7 @@ class IO return "" if closed? || eof? # IO.select cannot be used here due to the fact that it # just does not work on windows - while true + loop do begin IO.select([self], nil, nil, select_timeout) break if eof? # stop raising :-( |