diff options
author | Colby Swandale <me@colby.fyi> | 2019-06-12 17:48:05 +1000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-06-12 17:48:05 +1000 |
commit | 293d743dbcf9fd04d398bc1b5b5d26c17539a948 (patch) | |
tree | c9c7c975b1ae5a399d56433893f8071645acadca | |
parent | f54469ebb68b331ac676e5f0dbbdc41c70e9540a (diff) | |
parent | 50c3395479ff9bca569212fbdc3a6e8743b92802 (diff) | |
download | bundler-293d743dbcf9fd04d398bc1b5b5d26c17539a948.tar.gz |
Merge #6798 into `2-0-stable` (#7182)
Merge #6798 into `2-0-stable`
-rw-r--r-- | lib/bundler/dsl.rb | 2 | ||||
-rw-r--r-- | spec/bundler/dsl_spec.rb | 6 | ||||
-rw-r--r-- | spec/other/major_deprecation_spec.rb | 13 |
3 files changed, 5 insertions, 16 deletions
diff --git a/lib/bundler/dsl.rb b/lib/bundler/dsl.rb index 90ac073c36..285b155197 100644 --- a/lib/bundler/dsl.rb +++ b/lib/bundler/dsl.rb @@ -305,7 +305,7 @@ module Bundler # end repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/") # TODO: 2.0 upgrade this setting to the default - if Bundler.settings["github.https"] + if Bundler.feature_flag.github_https? Bundler::SharedHelpers.major_deprecation 3, "The `github.https` setting will be removed" "https://github.com/#{repo_name}.git" else diff --git a/spec/bundler/dsl_spec.rb b/spec/bundler/dsl_spec.rb index 94d54ad877..8aeca6414a 100644 --- a/spec/bundler/dsl_spec.rb +++ b/spec/bundler/dsl_spec.rb @@ -44,7 +44,7 @@ RSpec.describe Bundler::Dsl do it "converts :github to :git" do subject.gem("sparks", :github => "indirect/sparks") - github_uri = "git://github.com/indirect/sparks.git" + github_uri = "https://github.com/indirect/sparks.git" expect(subject.dependencies.first.source.uri).to eq(github_uri) end @@ -62,7 +62,7 @@ RSpec.describe Bundler::Dsl do it "converts 'rails' to 'rails/rails'" do subject.gem("rails", :github => "rails") - github_uri = "git://github.com/rails/rails.git" + github_uri = "https://github.com/rails/rails.git" expect(subject.dependencies.first.source.uri).to eq(github_uri) end @@ -253,7 +253,7 @@ RSpec.describe Bundler::Dsl do end subject.dependencies.each do |d| - expect(d.source.uri).to eq("git://github.com/spree/spree.git") + expect(d.source.uri).to eq("https://github.com/spree/spree.git") end end end diff --git a/spec/other/major_deprecation_spec.rb b/spec/other/major_deprecation_spec.rb index 50800dbb0c..0a3c65a1e5 100644 --- a/spec/other/major_deprecation_spec.rb +++ b/spec/other/major_deprecation_spec.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -RSpec.describe "major deprecations", :bundler => "< 3" do +RSpec.describe "major deprecations", :bundler => "<= 2" do let(:warnings) { last_command.bundler_err } # change to err in 2.0 let(:warnings_without_version_messages) { warnings.gsub(/#{Spec::Matchers::MAJOR_DEPRECATION}Bundler will only support ruby(gems)? >= .*/, "") } @@ -198,17 +198,6 @@ RSpec.describe "major deprecations", :bundler => "< 3" do end context "with github gems" do - it "warns about the https change" do - msg = <<-EOS -The :github git source is deprecated, and will be removed in Bundler 3.0. Change any "reponame" :github sources to "username/reponame". Add this code to the top of your Gemfile to ensure it continues to work: - - git_source(:github) {|repo_name| "https://github.com/\#{repo_name}.git" } - - EOS - expect(Bundler::SharedHelpers).to receive(:major_deprecation).with(3, msg) - subject.gem("sparks", :github => "indirect/sparks") - end - it "upgrades to https on request" do Bundler.settings.temporary "github.https" => true msg = <<-EOS |