summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorchrismo <chrismo@clabs.org>2016-06-21 00:05:00 -0500
committerchrismo <chrismo@clabs.org>2016-07-08 19:35:57 -0500
commitbdc1df50535b15a9a263410dbe4789571a115ff5 (patch)
tree8cf0fa2ffb2224fe2ae6286ce1b7185de0c469d5
parent20426a810877465897594269a2829cd4fe9bbde0 (diff)
downloadbundler-bdc1df50535b15a9a263410dbe4789571a115ff5.tar.gz
Add spec to definition for gem version promoter.
-rw-r--r--lib/bundler/definition.rb1
-rw-r--r--lib/bundler/gem_version_promoter.rb2
-rw-r--r--spec/bundler/definition_spec.rb18
-rw-r--r--spec/bundler/gem_version_promoter_spec.rb0
4 files changed, 19 insertions, 2 deletions
diff --git a/lib/bundler/definition.rb b/lib/bundler/definition.rb
index e088d81009..0f8d0ee6e1 100644
--- a/lib/bundler/definition.rb
+++ b/lib/bundler/definition.rb
@@ -126,7 +126,6 @@ module Bundler
end
def create_gem_version_promoter
- # MODO: unit test this
locked_specs = begin
if @unlocking && @locked_specs.empty?
# Definition uses an empty set of locked_specs to indicate all gems
diff --git a/lib/bundler/gem_version_promoter.rb b/lib/bundler/gem_version_promoter.rb
index 2f3b919d4b..f89e8ca8a7 100644
--- a/lib/bundler/gem_version_promoter.rb
+++ b/lib/bundler/gem_version_promoter.rb
@@ -1,7 +1,7 @@
# frozen_string_literal: true
module Bundler
class GemVersionPromoter
- attr_reader :level
+ attr_reader :level, :locked_specs, :unlock_gems
attr_accessor :strict, :minimal
def initialize(locked_specs = SpecSet.new([]), unlock_gems = [])
diff --git a/spec/bundler/definition_spec.rb b/spec/bundler/definition_spec.rb
index a8ee3080f1..a6e0436cc3 100644
--- a/spec/bundler/definition_spec.rb
+++ b/spec/bundler/definition_spec.rb
@@ -133,4 +133,22 @@ describe Bundler::Definition do
G
end
end
+
+ describe "initialize" do
+ context "gem version promoter" do
+ before :each do
+ install_gemfile <<-G
+ source "file://#{gem_repo1}"
+ gem "foo"
+ G
+ end
+
+ it "should get a locked specs list when updating all" do
+ definition = Bundler::Definition.new(bundled_app("Gemfile.lock"), [], Bundler::SourceList.new, true)
+ locked_specs = definition.gem_version_promoter.locked_specs
+ expect(locked_specs.to_a.map(&:name)).to eq ["foo"]
+ expect(definition.instance_variable_get("@locked_specs").empty?).to eq true
+ end
+ end
+ end
end
diff --git a/spec/bundler/gem_version_promoter_spec.rb b/spec/bundler/gem_version_promoter_spec.rb
new file mode 100644
index 0000000000..e69de29bb2
--- /dev/null
+++ b/spec/bundler/gem_version_promoter_spec.rb