diff options
| author | The Bundler Bot <bot@bundler.io> | 2017-09-14 04:45:52 +0000 |
|---|---|---|
| committer | Samuel Giddins <segiddins@segiddins.me> | 2017-09-18 13:43:47 -0500 |
| commit | e9eeb951027d7f28a6aa881c6401bba2d25c229a (patch) | |
| tree | 295497a97672a115c779e8bf6558860dde61bc59 | |
| parent | b26899bb88fccd8fd68a2a21ee2ccc1b68681b23 (diff) | |
| download | bundler-e9eeb951027d7f28a6aa881c6401bba2d25c229a.tar.gz | |
Auto merge of #6031 - bundler:seg-disable-new-version-warning-by-default, r=indirect
[CLI] For now, disable the new version warning by default
### What was the end-user problem that led to this PR?
The problem was people were getting confused by the terseness and bluntness of the current outdated bundler version warning.
### What was your diagnosis of the problem?
My diagnosis was we need to spend time fine-tuning the message, including when it is displayed. But given the lack of time to do so immediately, I thought it best to disable the warning for now, until someone can make a PR that addresses the comments and concerns raised in #6004.
(cherry picked from commit 8609a064aacb8d187053a4fc187c0993aca35707)
| -rw-r--r-- | lib/bundler/settings.rb | 1 | ||||
| -rw-r--r-- | spec/bundler/cli_spec.rb | 2 |
2 files changed, 3 insertions, 0 deletions
diff --git a/lib/bundler/settings.rb b/lib/bundler/settings.rb index dee7c14ca1..f33e9453be 100644 --- a/lib/bundler/settings.rb +++ b/lib/bundler/settings.rb @@ -68,6 +68,7 @@ module Bundler ].freeze DEFAULT_CONFIG = { + :disable_version_check => true, :redirect => 5, :retry => 3, :timeout => 10, diff --git a/spec/bundler/cli_spec.rb b/spec/bundler/cli_spec.rb index 5b48808e44..16ca32ca19 100644 --- a/spec/bundler/cli_spec.rb +++ b/spec/bundler/cli_spec.rb @@ -96,6 +96,8 @@ RSpec.describe "bundle executable" do let(:bundler_version) { "1.1" } let(:latest_version) { nil } before do + bundle! "config --global disable_version_check false" + simulate_bundler_version(bundler_version) if latest_version info_path = home(".bundle/cache/compact_index/rubygems.org.443.29b0360b937aa4d161703e6160654e47/info/bundler") |