diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-03-31 11:32:44 +0200 |
---|---|---|
committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-03-31 11:57:48 +0200 |
commit | c36113befda160b7efeb4bbb60258006dd65848f (patch) | |
tree | 1715033a66cfb12d8e9a70e422e072cb2412180c | |
parent | 61a56579cb6232fc02967ea2264b623ee64f16c6 (diff) | |
download | bundler-c36113befda160b7efeb4bbb60258006dd65848f.tar.gz |
Remove `viz_command` setting
This setting is not meant to be used by end users. The `viz` command is
going away and we plan to fully remove the code once we only have to
maintain bundler 3 or higher versions. Adding a setting makes it look
like the presence of this command is something "configurable", but it's
not.
-rw-r--r-- | lib/bundler/cli.rb | 2 | ||||
-rw-r--r-- | lib/bundler/feature_flag.rb | 1 | ||||
-rw-r--r-- | lib/bundler/settings.rb | 1 | ||||
-rw-r--r-- | spec/quality_spec.rb | 1 |
4 files changed, 1 insertions, 4 deletions
diff --git a/lib/bundler/cli.rb b/lib/bundler/cli.rb index 00ee591731..03806fd4c4 100644 --- a/lib/bundler/cli.rb +++ b/lib/bundler/cli.rb @@ -524,7 +524,7 @@ module Bundler end end - if Bundler.feature_flag.viz_command? + unless Bundler.feature_flag.bundler_3_mode? desc "viz [OPTIONS]", "Generates a visual dependency graph", :hide => true long_desc <<-D Viz generates a PNG file of the current Gemfile as a dependency graph. diff --git a/lib/bundler/feature_flag.rb b/lib/bundler/feature_flag.rb index 5e5d97ec42..df90a526c7 100644 --- a/lib/bundler/feature_flag.rb +++ b/lib/bundler/feature_flag.rb @@ -56,7 +56,6 @@ module Bundler settings_flag(:unlock_source_unlocks_spec) { !bundler_2_mode? } settings_flag(:update_requires_all_flag) { bundler_3_mode? } settings_flag(:use_gem_version_promoter_for_major_updates) { bundler_2_mode? } - settings_flag(:viz_command) { !bundler_3_mode? } settings_option(:default_cli_command) { bundler_2_mode? ? :cli_help : :install } diff --git a/lib/bundler/settings.rb b/lib/bundler/settings.rb index 3bec5c8c3b..05fa000e0f 100644 --- a/lib/bundler/settings.rb +++ b/lib/bundler/settings.rb @@ -60,7 +60,6 @@ module Bundler unlock_source_unlocks_spec update_requires_all_flag use_gem_version_promoter_for_major_updates - viz_command ].freeze NUMBER_KEYS = %w[ diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb index 3ae22e4adb..5e57177a6c 100644 --- a/spec/quality_spec.rb +++ b/spec/quality_spec.rb @@ -176,7 +176,6 @@ RSpec.describe "The library itself" do inline lockfile_uses_separate_rubygems_sources use_gem_version_promoter_for_major_updates - viz_command ] all_settings = Hash.new {|h, k| h[k] = [] } |