run rubocop with --auto-gen-config

2 files changed, 56 insertions, 42 deletions

diff --git a/.rubocop.yml b/.rubocop.yml
index a6412ecb13..cbdb8f8d41 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -2,7 +2,7 @@ inherit_from:
   - .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 1.9
+  TargetRubyVersion: 2.3
   Exclude:
     - tmp/**/*
     - lib/bundler/vendor/**/*
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index f411b8e11d..16080de7cd 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-05-30 06:35:02 +0900 using RuboCop version 0.49.1.
+# on 2018-10-29 22:50:33 +1100 using RuboCop version 0.49.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,13 +12,6 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Exclude:
-    - 'lib/bundler/cli.rb'
-
 # Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: SupportedStyles, IndentationWidth.
@@ -26,7 +19,7 @@ Layout/ExtraSpacing:
 Layout/IndentArray:
   EnforcedStyle: consistent
 
-# Offense count: 35
+# Offense count: 48
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
@@ -58,7 +51,7 @@ Layout/SpaceInsideBlockBraces:
   Exclude:
     - 'lib/bundler/installer/parallel_installer.rb'
 
-# Offense count: 25
+# Offense count: 30
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'lib/bundler/definition.rb'
@@ -67,8 +60,8 @@ Lint/AmbiguousBlockAssociation:
     - 'spec/commands/init_spec.rb'
     - 'spec/commands/install_spec.rb'
     - 'spec/install/gems/flex_spec.rb'
-    - 'spec/lock/lockfile_spec.rb'
     - 'spec/lock/lockfile_bundler_1_spec.rb'
+    - 'spec/lock/lockfile_spec.rb'
     - 'spec/other/major_deprecation_spec.rb'
     - 'spec/runtime/setup_spec.rb'
     - 'spec/support/helpers.rb'
@@ -83,7 +76,6 @@ Lint/EmptyWhen:
 # Offense count: 4
 Lint/HandleExceptions:
   Exclude:
-    - 'lib/bundler/installer.rb'
     - 'lib/bundler/psyched_yaml.rb'
     - 'lib/bundler/vendored_persistent.rb'
 
@@ -119,13 +111,12 @@ Lint/UselessAccessModifier:
   Exclude:
     - 'lib/bundler/fetcher.rb'
 
-# Offense count: 6
+# Offense count: 1
 Lint/UselessAssignment:
   Exclude:
     - 'lib/bundler/index.rb'
-    - 'lib/bundler/installer.rb'
 
-# Offense count: 2085
+# Offense count: 2779
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
@@ -175,13 +166,6 @@ Security/MarshalLoad:
     - 'spec/support/artifice/compact_index.rb'
     - 'spec/support/artifice/endpoint.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Security/YAMLLoad:
-  Exclude:
-    - 'spec/bundler/yaml_serializer_spec.rb'
-    - 'spec/commands/inject_spec.rb'
-
 # Offense count: 1
 Style/AccessorMethodName:
   Exclude:
@@ -193,7 +177,7 @@ Style/CaseEquality:
     - 'lib/bundler/match_platform.rb'
     - 'lib/bundler/rubygems_ext.rb'
 
-# Offense count: 27
+# Offense count: 28
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
@@ -215,7 +199,7 @@ Style/ConditionalAssignment:
     - 'lib/bundler/source/git.rb'
     - 'lib/bundler/source/rubygems.rb'
 
-# Offense count: 160
+# Offense count: 168
 Style/Documentation:
   Enabled: false
 
@@ -238,19 +222,17 @@ Style/EmptyMethod:
 Style/FormatStringToken:
   EnforcedStyle: template
 
-# Offense count: 2
+# Offense count: 1
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
   Exclude:
     - 'lib/bundler/cli.rb'
-    - 'spec/spec_helper.rb'
 
-# Offense count: 16
+# Offense count: 12
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
     - 'lib/bundler/cli/cache.rb'
-    - 'lib/bundler/cli/clean.rb'
     - 'lib/bundler/cli/install.rb'
     - 'lib/bundler/cli/outdated.rb'
     - 'lib/bundler/cli/package.rb'
@@ -263,20 +245,12 @@ Style/GuardClause:
     - 'spec/support/sometimes.rb'
 
 # Offense count: 1
-Style/IfInsideElse:
-  Exclude:
-    - 'lib/bundler/cli/install.rb'
-
-# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
 Style/IfUnlessModifier:
   Exclude:
     - 'lib/bundler/dsl.rb'
 
-# Offense count: 1
-Style/IfUnlessModifierOfIfUnless:
-  Exclude:
-    - 'spec/support/helpers.rb'
-
 # Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: InverseMethods, InverseBlocks.
@@ -315,7 +289,7 @@ Style/ModuleFunction:
     - 'lib/bundler/shared_helpers.rb'
     - 'spec/support/path.rb'
 
-# Offense count: 11
+# Offense count: 10
 # Cop supports --auto-correct.
 Style/MultilineIfModifier:
   Exclude:
@@ -334,13 +308,14 @@ Style/NestedParenthesizedCalls:
     - 'spec/commands/lock_spec.rb'
     - 'spec/runtime/setup_spec.rb'
 
-# Offense count: 6
+# Offense count: 7
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
     - 'spec/**/*'
+    - 'lib/bundler/cli/common.rb'
     - 'lib/bundler/gem_helper.rb'
     - 'lib/bundler/mirror.rb'
     - 'lib/bundler/source/git/git_proxy.rb'
@@ -383,12 +358,51 @@ Style/RaiseArgs:
     - 'spec/bundler/rubygems_integration_spec.rb'
     - 'spec/bundler/shared_helpers_spec.rb'
 
+# Offense count: 24
+# Cop supports --auto-correct.
+Style/RedundantFreeze:
+  Exclude:
+    - 'bin/bundle1'
+    - 'bin/bundle2'
+    - 'lib/bundler.rb'
+    - 'lib/bundler/endpoint_specification.rb'
+    - 'lib/bundler/environment_preserver.rb'
+    - 'lib/bundler/index.rb'
+    - 'lib/bundler/injector.rb'
+    - 'lib/bundler/installer.rb'
+    - 'lib/bundler/lockfile_generator.rb'
+    - 'lib/bundler/lockfile_parser.rb'
+    - 'lib/bundler/plugin.rb'
+    - 'lib/bundler/resolver/spec_group.rb'
+    - 'lib/bundler/source/path.rb'
+    - 'spec/bundler/shared_helpers_spec.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/RedundantParentheses:
   Exclude:
     - 'lib/bundler/cli/console.rb'
 
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil.
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/bundler/cli/add.rb'
+    - 'lib/bundler/fetcher/compact_index.rb'
+    - 'lib/bundler/gem_helper.rb'
+    - 'lib/bundler/gem_remote_fetcher.rb'
+    - 'lib/bundler/rubygems_integration.rb'
+    - 'lib/bundler/source/rubygems.rb'
+    - 'spec/support/artifice/vcr.rb'
+
+# Offense count: 56
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize, SupportedStyles.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
@@ -412,7 +426,7 @@ Style/TrailingCommaInLiteral:
     - 'lib/bundler/similarity_detector.rb'
     - 'spec/support/artifice/endpoint.rb'
 
-# Offense count: 7
+# Offense count: 14
 # Cop supports --auto-correct.
 Style/UnneededInterpolation:
   Exclude: