Merge #6964

6964: Dependency review r=segiddins a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that we were using some outdated test dependencies.

### What was your diagnosis of the problem?

My diagnosis was that we can upgrade them, since the comments justifying them being pinned are no longer relevant.

### What is your fix for the problem, implemented in this PR?

My fix is to unpin the dependencies, and remove the comments no longer applying.

### Why did you choose this fix out of the possible options?

I chose this fix because it was the only fix I could think of.


Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

1 files changed, 6 insertions, 13 deletions

diff --git a/spec/support/rubygems_ext.rb b/spec/support/rubygems_ext.rb
index 21967756ec..c13ed35413 100644
--- a/spec/support/rubygems_ext.rb
+++ b/spec/support/rubygems_ext.rb
@@ -6,26 +6,19 @@ require "support/path" unless defined?(Spec::Path)
 module Spec
   module Rubygems
     DEPS = begin
-      deps = {
-        # rack 2.x requires Ruby version >= 2.2.2.
+      {
         # artifice doesn't support rack 2.x now.
-        # TODO: revert to `< 2` once https://github.com/rack/rack/issues/1168 is
-        # addressed
-        "rack" => "1.6.6",
-        # rack-test 0.7.0 dropped 1.8.7 support
-        # https://github.com/rack-test/rack-test/issues/193#issuecomment-314230318
-        "rack-test" => "< 0.7.0",
+        "rack" => "< 2.0",
+        "rack-test" => "~> 1.1",
         "artifice" => "~> 0.6.0",
         "compact_index" => "~> 0.11.0",
         "sinatra" => "~> 1.4.7",
         # Rake version has to be consistent for tests to pass
         "rake" => "12.3.2",
-        # 3.0.0 breaks 1.9.2 specs
-        "builder" => "2.1.2",
+        "builder" => "~> 3.2",
+        # ruby-graphviz is used by the viz tests
+        "ruby-graphviz" => nil,
       }
-      # ruby-graphviz is used by the viz tests
-      deps["ruby-graphviz"] = nil if RUBY_VERSION >= "1.9.3"
-      deps
     end
 
     def self.setup