diff options
author | Bundlerbot <bot@bundler.io> | 2019-08-05 16:35:23 +0000 |
---|---|---|
committer | Bundlerbot <bot@bundler.io> | 2019-08-05 16:35:23 +0000 |
commit | 39850efe40e4a34439657c2678008658b03274db (patch) | |
tree | a30aa814b82cce756d4d60fbaa9d63dddbdbf42f | |
parent | e1c518363641208429f397170354054b3d28effd (diff) | |
parent | da360659f79ebaff0c26a9db143019bf3cb0af97 (diff) | |
download | bundler-39850efe40e4a34439657c2678008658b03274db.tar.gz |
Merge #7276
7276: Enable retries on flaky spec r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that master is unstable right now, and build fails a number of times. That makes merging PRs annoying because they have to be retried many times.
### What was your diagnosis of the problem?
I'm currently investigating what's going on and found the first root cause. Sometimes specs end up falling back to the old dependency API, and we have no recorded cassettes for those request, so specs fail because those never recorded specs are not allowed to be performed. I'm now invetigating the cause for that and I have a hypothesis: previous specs are sometimes messing up the test user home, and that's why we're falling back.
I yet need to validate this hypothesis and find a fix, but I discovered that we have a mechanism in place for retrying failed specs.
### What is your fix for the problem, implemented in this PR?
My fix is to enable the mechanism for the time being to reduce flakyness of our CI and unblock other PRs
### Why did you choose this fix out of the possible options?
I chose this fix because I don't want other finished PRs to have to wait for me fixing this, or to have to be retried many times so that they can be merged.
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
-rw-r--r-- | spec/realworld/double_check_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/realworld/double_check_spec.rb b/spec/realworld/double_check_spec.rb index 6fee578a71..07593ac493 100644 --- a/spec/realworld/double_check_spec.rb +++ b/spec/realworld/double_check_spec.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -RSpec.describe "double checking sources", :realworld => true do +RSpec.describe "double checking sources", :realworld => true, :sometimes => true do it "finds already-installed gems" do create_file("rails.gemspec", <<-RUBY) Gem::Specification.new do |s| |