summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2019-02-20 15:56:01 +0100
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2019-02-28 16:41:20 +0100
commitf89bca863fdaec498d19b2aabe88653a5c585d84 (patch)
tree49dae4c04185a10788b4f96bdc36c0fb75e52c7b
parentec56cdbd64c9ba920946e0fc3e823257189c8196 (diff)
downloadbundler-f89bca863fdaec498d19b2aabe88653a5c585d84.tar.gz
Delay requiring --all to update everything to bundler 3
Since we haven't even yet deprecated the old behavior.
-rw-r--r--lib/bundler/feature_flag.rb2
-rw-r--r--spec/other/major_deprecation_spec.rb7
2 files changed, 7 insertions, 2 deletions
diff --git a/lib/bundler/feature_flag.rb b/lib/bundler/feature_flag.rb
index 0adbd9190f..4dd104e3b2 100644
--- a/lib/bundler/feature_flag.rb
+++ b/lib/bundler/feature_flag.rb
@@ -54,7 +54,7 @@ module Bundler
settings_flag(:specific_platform) { bundler_2_mode? }
settings_flag(:suppress_install_using_messages) { bundler_2_mode? }
settings_flag(:unlock_source_unlocks_spec) { !bundler_2_mode? }
- settings_flag(:update_requires_all_flag) { bundler_2_mode? }
+ settings_flag(:update_requires_all_flag) { bundler_3_mode? }
settings_flag(:use_gem_version_promoter_for_major_updates) { bundler_2_mode? }
settings_flag(:viz_command) { !bundler_2_mode? }
diff --git a/spec/other/major_deprecation_spec.rb b/spec/other/major_deprecation_spec.rb
index da8d1f56f4..09c3bdb7fa 100644
--- a/spec/other/major_deprecation_spec.rb
+++ b/spec/other/major_deprecation_spec.rb
@@ -45,7 +45,12 @@ RSpec.describe "major deprecations", :bundler => "< 2" do
bundle! "install"
end
- it "warns when no options are given" do
+ it "does not warn when no options are given", :bundler => "< 2" do
+ bundle! "update"
+ expect(warnings).not_to have_major_deprecation
+ end
+
+ it "warns when no options are given", :bundler => "2" do
bundle! "update"
expect(warnings).to have_major_deprecation a_string_including("Pass --all to `bundle update` to update everything")
end