Auto merge of #6038 - bundler:colby/rubocop-050, r=olleolleolle

update rubocop to 0.50

This PR just updates rubocop to 0.50

(cherry picked from commit 0a672a1deb01fa4ce8b51eb2f5b545692c64cd83)

2 files changed, 100 insertions, 46 deletions

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 7f97d0ecc4..832870b8c5 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-10-29 23:00:23 +1100 using RuboCop version 0.49.1.
+# on 2019-04-04 19:50:10 +1100 using RuboCop version 0.50.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -19,7 +19,7 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords:
 Layout/IndentArray:
   EnforcedStyle: consistent
 
-# Offense count: 48
+# Offense count: 46
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
@@ -67,6 +67,11 @@ Lint/AmbiguousBlockAssociation:
     - 'spec/support/helpers.rb'
     - 'spec/support/indexes.rb'
 
+# Offense count: 1
+Lint/DuplicateMethods:
+  Exclude:
+    - 'lib/bundler/rubygems_ext.rb'
+
 # Offense count: 2
 Lint/EmptyWhen:
   Exclude:
@@ -84,6 +89,15 @@ Lint/IneffectiveAccessModifier:
   Exclude:
     - 'lib/bundler/settings.rb'
 
+# Offense count: 6
+Lint/InterpolationCheck:
+  Exclude:
+    - 'lib/bundler/dsl.rb'
+    - 'lib/bundler/installer/standalone.rb'
+    - 'spec/commands/binstubs_spec.rb'
+    - 'spec/install/gems/standalone_spec.rb'
+    - 'spec/other/major_deprecation_spec.rb'
+
 # Offense count: 3
 Lint/NestedMethodDefinition:
   Exclude:
@@ -99,6 +113,19 @@ Lint/RescueException:
     - 'lib/bundler/rubygems_integration.rb'
     - 'lib/bundler/worker.rb'
 
+# Offense count: 14
+Lint/RescueWithoutErrorClass:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/bundler/friendly_errors.rb'
+    - 'lib/bundler/installer.rb'
+    - 'lib/bundler/resolver.rb'
+    - 'lib/bundler/retry.rb'
+    - 'spec/support/artifice/compact_index.rb'
+    - 'spec/support/helpers.rb'
+    - 'spec/support/matchers.rb'
+    - 'task/release.rake'
+
 # Offense count: 2
 Lint/ShadowedException:
   Exclude:
@@ -116,18 +143,63 @@ Lint/UselessAssignment:
   Exclude:
     - 'lib/bundler/index.rb'
 
-# Offense count: 2785
+# Offense count: 1
+Lint/Void:
+  Exclude:
+    - 'lib/bundler/spec_set.rb'
+
+# Offense count: 2800
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
   Max: 207
 
+# Offense count: 1
+Naming/AccessorMethodName:
+  Exclude:
+    - 'lib/bundler/source/git.rb'
+
+# Offense count: 32
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+  Enabled: false
+
+# Offense count: 9
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/bundler/definition.rb'
+    - 'lib/bundler/installer/parallel_installer.rb'
+    - 'lib/bundler/settings.rb'
+    - 'lib/bundler/source/git.rb'
+    - 'lib/bundler/source/git/git_proxy.rb'
+    - 'lib/bundler/source/path.rb'
+
 # Offense count: 2
 Performance/Caller:
   Exclude:
     - 'lib/bundler/rubygems_integration.rb'
     - 'spec/support/builders.rb'
 
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect.
+Performance/HashEachMethods:
+  Exclude:
+    - 'lib/bundler/definition.rb'
+    - 'lib/bundler/dependency.rb'
+    - 'lib/bundler/dsl.rb'
+    - 'lib/bundler/index.rb'
+    - 'lib/bundler/plugin.rb'
+    - 'spec/install/gems/standalone_spec.rb'
+    - 'spec/support/builders.rb'
+    - 'spec/support/helpers.rb'
+
 # Offense count: 7
 # Cop supports --auto-correct.
 Performance/RedundantBlockCall:
@@ -151,6 +223,10 @@ Performance/RedundantMerge:
   Exclude:
     - 'lib/bundler/cli/gem.rb'
 
+# Offense count: 37
+Performance/UnfreezeString:
+  Enabled: false
+
 # Offense count: 4
 Security/Eval:
   Exclude:
@@ -166,11 +242,6 @@ Security/MarshalLoad:
     - 'spec/support/artifice/compact_index.rb'
     - 'spec/support/artifice/endpoint.rb'
 
-# Offense count: 1
-Style/AccessorMethodName:
-  Exclude:
-    - 'lib/bundler/source/git.rb'
-
 # Offense count: 3
 Style/CaseEquality:
   Exclude:
@@ -216,6 +287,19 @@ Style/EmptyMethod:
     - 'lib/bundler/ui/silent.rb'
     - 'spec/support/artifice/fail.rb'
 
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AutoCorrectEncodingComment.
+# SupportedStyles: when_needed, always, never
+Style/Encoding:
+  Exclude:
+    - 'Rakefile'
+    - 'bundler.gemspec'
+    - 'lib/bundler/friendly_errors.rb'
+    - 'spec/bundler/bundler_spec.rb'
+    - 'spec/install/gemfile_spec.rb'
+    - 'spec/install/gemspecs_spec.rb'
+
 # Offense count: 1
 # Configuration parameters: SupportedStyles.
 # SupportedStyles: annotated, template
@@ -229,7 +313,7 @@ Style/GlobalVars:
     - 'lib/bundler/cli.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 12
+# Offense count: 11
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
@@ -242,7 +326,6 @@ Style/GuardClause:
     - 'lib/bundler/runtime.rb'
     - 'lib/bundler/source/path/installer.rb'
     - 'lib/bundler/source_list.rb'
-    - 'spec/commands/newgem_spec.rb'
     - 'spec/support/sometimes.rb'
 
 # Offense count: 1
@@ -274,14 +357,6 @@ Style/MethodMissing:
     - 'lib/bundler/remote_specification.rb'
     - 'spec/support/builders.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: separated, grouped
-Style/MixinGrouping:
-  Exclude:
-    - 'lib/bundler/spec_set.rb'
-
 # Offense count: 2
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: module_function, extend_self
@@ -303,13 +378,15 @@ Style/MultilineIfModifier:
 
 # Offense count: 3
 # Cop supports --auto-correct.
+# Configuration parameters: Whitelist.
+# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
 Style/NestedParenthesizedCalls:
   Exclude:
     - 'lib/bundler/resolver.rb'
     - 'spec/commands/lock_spec.rb'
     - 'spec/runtime/setup_spec.rb'
 
-# Offense count: 7
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
 # SupportedStyles: predicate, comparison
@@ -319,22 +396,6 @@ Style/NumericPredicate:
     - 'lib/bundler/cli/common.rb'
     - 'lib/bundler/gem_helper.rb'
     - 'lib/bundler/mirror.rb'
-    - 'lib/bundler/source/git/git_proxy.rb'
-    - 'lib/bundler/source/path.rb'
-
-# Offense count: 9
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
-# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
-Style/PredicateName:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/bundler/definition.rb'
-    - 'lib/bundler/installer/parallel_installer.rb'
-    - 'lib/bundler/settings.rb'
-    - 'lib/bundler/source/git.rb'
-    - 'lib/bundler/source/git/git_proxy.rb'
     - 'lib/bundler/source/path.rb'
 
 # Offense count: 24
@@ -384,20 +445,13 @@ Style/RedundantParentheses:
   Exclude:
     - 'lib/bundler/cli/console.rb'
 
-# Offense count: 7
+# Offense count: 41
 # Cop supports --auto-correct.
 # Configuration parameters: ConvertCodeThatCanStartToReturnNil.
 Style/SafeNavigation:
-  Exclude:
-    - 'lib/bundler/cli/add.rb'
-    - 'lib/bundler/fetcher/compact_index.rb'
-    - 'lib/bundler/gem_helper.rb'
-    - 'lib/bundler/gem_remote_fetcher.rb'
-    - 'lib/bundler/rubygems_integration.rb'
-    - 'lib/bundler/source/rubygems.rb'
-    - 'spec/support/artifice/vcr.rb'
+  Enabled: false
 
-# Offense count: 56
+# Offense count: 57
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize, SupportedStyles.
 # SupportedStyles: percent, brackets
diff --git a/bin/rubocop b/bin/rubocop
index 98ce0c89c2..81f4679fb8 100755
--- a/bin/rubocop
+++ b/bin/rubocop
@@ -10,7 +10,7 @@ bundler_spec.dependencies.each do |dep|
   gem dep.name, dep.requirement
 end
 
-gem "rubocop", "= 0.49.1"
+gem "rubocop", "= 0.50.0"
 
 Gem.finish_resolve if Gem.respond_to?(:finish_resolve)