diff options
| author | The Bundler Bot <bot@bundler.io> | 2017-11-08 21:04:47 +0000 |
|---|---|---|
| committer | The Bundler Bot <bot@bundler.io> | 2017-11-08 21:04:47 +0000 |
| commit | 914a4a8b8d0cf1a79dbc7b334fbb5c2db1ecdc16 (patch) | |
| tree | dd150665c7acf83fbc2d3a1b68cfb4c712b30054 | |
| parent | 892a637f2d9bf18b9898ea31d4f5bf8d1e8cb8e4 (diff) | |
| parent | 3b6bf5246e6e96e1d4970074abdfdf6b0b06bfe2 (diff) | |
| download | bundler-914a4a8b8d0cf1a79dbc7b334fbb5c2db1ecdc16.tar.gz | |
Auto merge of #6161 - bundler:indirect/update-pr-docs, r=segiddins
Stop requesting changelogs in PRs
We added this requirement before the changelog was automated. Now that the changelog generated by a script, it's not helpful for PRs to update the changelog anymore, so we shouldn't expect it anymore.
### What was the end-user problem that led to this PR?
We had to [ask a PR to remove a changelog entry](https://github.com/bundler/bundler/pull/6157#discussion_r149701953), even though the PR was following [the docs](https://github.com/bundler/bundler/blob/374caf6ede2cf4de7d2196aa2e2adef782bea5bd/doc/development/PULL_REQUESTS.md#changelogmd).
### What was your diagnosis of the problem?
It looks like we failed to update the docs when we automated generating the changelog.
### What is your fix for the problem, implemented in this PR?
Removing the changelog requirement from the docs hopefully means that future PRs will not include changelog entries, and we can generate future changelogs automatically.
### Why did you choose this fix out of the possible options?
I chose this fix because it seemed like the smallest change that would accomplish the goal.
/cc @mattbrictson
| -rw-r--r-- | doc/development/PULL_REQUESTS.md | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/doc/development/PULL_REQUESTS.md b/doc/development/PULL_REQUESTS.md index 292aacc529..497febfe71 100644 --- a/doc/development/PULL_REQUESTS.md +++ b/doc/development/PULL_REQUESTS.md @@ -34,7 +34,3 @@ Please ensure that the commit messages included in the pull request __do not__ h If you want to use these mechanisms, please instead include them in the pull request description. This prevents multiple notifications or references being created on commit rebases or pull request/branch force pushes. Additionally, do not use `[ci skip]` or `[skip ci]` mechanisms in your pull request titles/descriptions or commit messages. Every potential commit and pull request should run through Bundler's CI system. This applies to all changes/commits (ex. even a change to just documentation or the removal of a comment). - -## CHANGELOG.md - -Don't forget to add your changes into the CHANGELOG! If you're submitting documentation, note the changes under the "Documentation" heading. |