diff options
| author | Bundlerbot <bot@bundler.io> | 2019-09-17 08:43:33 +0000 |
|---|---|---|
| committer | Bundlerbot <bot@bundler.io> | 2019-09-17 08:43:33 +0000 |
| commit | ebe0b853d8f2ac93f9c69768ee6af2c18fbc9d87 (patch) | |
| tree | 0bf399b9488f5be5b53f0fa05018530ff31abeeb | |
| parent | 892b18be786ab891b2602f2126d9b033f1f591b1 (diff) | |
| parent | b6cc6f3d0f41c765c24041c81ba27d6205fad2d4 (diff) | |
| download | bundler-ebe0b853d8f2ac93f9c69768ee6af2c18fbc9d87.tar.gz | |
Merge #7358
7358: More release fixes r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
I just released [2.1.0.pre.2](https://rubygems.org/gems/bundler/versions/2.1.0.pre.2). It went smoother than 2.1.0.pre.1, but I still got an issue where I unintentionally pushed a release named "v" to github releases.
### What was your diagnosis of the problem?
My diagnosis was that the release task by default should use the version in the gemspec for the `release:github` tasks.
### What is your fix for the problem, implemented in this PR?
My fix adds that fallback.
### Why did you choose this fix out of the possible options?
I chose this fix because it does what the user expects when the task is not passed any arguments.
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
| -rw-r--r-- | CHANGELOG.md | 2 | ||||
| -rw-r--r-- | task/release.rake | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 068a39445c..6a2610f41b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,4 @@ -## 2.1.0.pre.2 +## 2.1.0.pre.2 (September 15, 2019) Bugfixes: diff --git a/task/release.rake b/task/release.rake index be0241bffb..cd66ff755d 100644 --- a/task/release.rake +++ b/task/release.rake @@ -131,7 +131,7 @@ namespace :release do desc "Push the release to Github releases" task :github, :version do |_t, args| - version = Gem::Version.new(args.version) + version = Gem::Version.new(args.version || bundler_spec.version) tag = "v#{version}" gh_api_post :path => "/repos/bundler/bundler/releases", |