diff options
| author | Homu <homu@barosl.com> | 2015-07-23 11:33:14 +0900 |
|---|---|---|
| committer | Homu <homu@barosl.com> | 2015-07-23 11:33:14 +0900 |
| commit | 4d6c32be29d745fadef04380758b6f68817fbb33 (patch) | |
| tree | d7658d4aa92ce540a6f03c38d1fe0b09fd51c86f | |
| parent | 26f13d1bd365d6d3657e21ba99a9d861624649ea (diff) | |
| parent | 02f33e6c46bd1df5a317dbb4c84090cc5f0a712b (diff) | |
| download | bundler-4d6c32be29d745fadef04380758b6f68817fbb33.tar.gz | |
Auto merge of #3875 - esasse:rubocop-fix, r=segiddins
Fix Performance/ReverseEach
| -rw-r--r-- | .rubocop_todo.yml | 5 | ||||
| -rw-r--r-- | lib/bundler/cli.rb | 2 | ||||
| -rw-r--r-- | lib/bundler/source/rubygems.rb | 2 |
3 files changed, 2 insertions, 7 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cc3636e380..ab75eace17 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -53,11 +53,6 @@ Metrics/ParameterLists: Metrics/PerceivedComplexity: Max: 54 -# Offense count: 2 -# Cop supports --auto-correct. -Performance/ReverseEach: - Enabled: false - # Offense count: 1 Style/AccessorMethodName: Enabled: false diff --git a/lib/bundler/cli.rb b/lib/bundler/cli.rb index c11567640c..7ed8a6fdad 100644 --- a/lib/bundler/cli.rb +++ b/lib/bundler/cli.rb @@ -316,7 +316,7 @@ module Bundler desc "licenses", "Prints the license of all gems in the bundle" def licenses - Bundler.load.specs.sort_by {|s| s.license.to_s }.reverse.each do |s| + Bundler.load.specs.sort_by {|s| s.license.to_s }.reverse_each do |s| gem_name = s.name license = s.license || s.licenses diff --git a/lib/bundler/source/rubygems.rb b/lib/bundler/source/rubygems.rb index 9bd908fb60..f282edfd96 100644 --- a/lib/bundler/source/rubygems.rb +++ b/lib/bundler/source/rubygems.rb @@ -274,7 +274,7 @@ module Bundler @installed_specs ||= begin idx = Index.new have_bundler = false - Bundler.rubygems.all_specs.reverse.each do |spec| + Bundler.rubygems.all_specs.reverse_each do |spec| next if spec.name == "bundler" && spec.version.to_s != VERSION have_bundler = true if spec.name == "bundler" spec.source = self |