summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2019-03-31 11:35:36 +0200
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2019-03-31 11:57:49 +0200
commit714d2c7b440ad45d6aa8d503ffee3a4e941fecfe (patch)
tree80765c648b00847523d4fbd7a420a03fe0828dff
parentc36113befda160b7efeb4bbb60258006dd65848f (diff)
downloadbundler-714d2c7b440ad45d6aa8d503ffee3a4e941fecfe.tar.gz
Remove `console_command` settingremove_command_removal_settings
This setting is not meant to be used by end users. The `console` command is going away and we plan to fully remove the code once we only have to maintain bundler 3 or higher versions. Adding a setting makes it look like the presence of this command is something "configurable", but it's not.
-rw-r--r--lib/bundler/cli.rb2
-rw-r--r--lib/bundler/feature_flag.rb1
-rw-r--r--lib/bundler/settings.rb1
-rw-r--r--spec/quality_spec.rb1
4 files changed, 1 insertions, 4 deletions
diff --git a/lib/bundler/cli.rb b/lib/bundler/cli.rb
index 03806fd4c4..3dc90c04dc 100644
--- a/lib/bundler/cli.rb
+++ b/lib/bundler/cli.rb
@@ -487,7 +487,7 @@ module Bundler
Open.new(options, name).run
end
- if Bundler.feature_flag.console_command?
+ unless Bundler.feature_flag.bundler_3_mode?
desc "console [GROUP]", "Opens an IRB session with the bundle pre-loaded"
def console(group = nil)
require "bundler/cli/console"
diff --git a/lib/bundler/feature_flag.rb b/lib/bundler/feature_flag.rb
index df90a526c7..6347e46900 100644
--- a/lib/bundler/feature_flag.rb
+++ b/lib/bundler/feature_flag.rb
@@ -33,7 +33,6 @@ module Bundler
settings_flag(:auto_config_jobs) { bundler_2_mode? }
settings_flag(:cache_all) { bundler_2_mode? }
settings_flag(:cache_command_is_package) { bundler_2_mode? }
- settings_flag(:console_command) { !bundler_3_mode? }
settings_flag(:default_install_uses_path) { bundler_2_mode? }
settings_flag(:deployment_means_frozen) { bundler_2_mode? }
settings_flag(:disable_multisource) { bundler_2_mode? }
diff --git a/lib/bundler/settings.rb b/lib/bundler/settings.rb
index 05fa000e0f..a1c0825d39 100644
--- a/lib/bundler/settings.rb
+++ b/lib/bundler/settings.rb
@@ -18,7 +18,6 @@ module Bundler
cache_all
cache_all_platforms
cache_command_is_package
- console_command
default_install_uses_path
deployment
deployment_means_frozen
diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb
index 5e57177a6c..c9df900647 100644
--- a/spec/quality_spec.rb
+++ b/spec/quality_spec.rb
@@ -167,7 +167,6 @@ RSpec.describe "The library itself" do
exemptions = %w[
auto_config_jobs
cache_command_is_package
- console_command
deployment_means_frozen
forget_cli_options
gem.coc