diff options
| author | Bundlerbot <bot@bundler.io> | 2019-07-05 05:32:33 +0000 |
|---|---|---|
| committer | Bundlerbot <bot@bundler.io> | 2019-07-05 05:32:33 +0000 |
| commit | 9381dd20e53a12c2cdf850ba5d48b6de574538b5 (patch) | |
| tree | 676796050d69fd239de464332f372d8385288365 | |
| parent | 27659b9bfd3173e11a3468e4ed91236592341cb8 (diff) | |
| parent | 3e350089db0f4f5d103e0835a9030bc255656cfc (diff) | |
| download | bundler-9381dd20e53a12c2cdf850ba5d48b6de574538b5.tar.gz | |
Merge #7233
7233: Add missing expectation r=hsbt a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was I noticed that this test was missing one assertion. See
https://github.com/bundler/bundler/blob/566cce0629a0f1a4d147195a34d494306269e1cf/lib/bundler/shared_helpers.rb#L77-L84
### What was your diagnosis of the problem?
My diagnosis was that it should be added.
### What is your fix for the problem, implemented in this PR?
My fix is to add the missing expectation.
### Why did you choose this fix out of the possible options?
I chose this fix because regardless of how implementation dependent this spec is, it should probably be complete.
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
| -rw-r--r-- | spec/bundler/shared_helpers_spec.rb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/spec/bundler/shared_helpers_spec.rb b/spec/bundler/shared_helpers_spec.rb index f24d85c241..3b30a1f49f 100644 --- a/spec/bundler/shared_helpers_spec.rb +++ b/spec/bundler/shared_helpers_spec.rb @@ -263,6 +263,7 @@ RSpec.describe Bundler::SharedHelpers do end it "calls the appropriate set methods" do + expect(subject).to receive(:set_bundle_variables) expect(subject).to receive(:set_path) expect(subject).to receive(:set_rubyopt) expect(subject).to receive(:set_rubylib) |