diff options
author | Homu <homu@barosl.com> | 2015-11-28 10:14:59 +0900 |
---|---|---|
committer | Homu <homu@barosl.com> | 2015-11-28 10:14:59 +0900 |
commit | d4cc7861615d5178eb0d944bbd0ec4121bedb86a (patch) | |
tree | ea151176f97b95de649c477b98e6713577f10f66 | |
parent | 437f604956e629e1b96270d87f6fdb05b189de2d (diff) | |
parent | 9e055dcbe11210edda955edb6b6722f1b2285bac (diff) | |
download | bundler-d4cc7861615d5178eb0d944bbd0ec4121bedb86a.tar.gz |
Auto merge of #4127 - TimMoore:comment-on-git-vs-https-github-urls, r=segiddins
Explain why we don't use HTTPS for github sources
There are frequent pull requests proposing this change, which has already been merged to 2-0-dev.
Hopefully, this will help avoid so much wasted time.
-rw-r--r-- | lib/bundler/dsl.rb | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/lib/bundler/dsl.rb b/lib/bundler/dsl.rb index 4755fe0609..4ef64e1258 100644 --- a/lib/bundler/dsl.rb +++ b/lib/bundler/dsl.rb @@ -220,6 +220,19 @@ module Bundler def add_git_sources git_source(:github) do |repo_name| + # It would be better to use https instead of the git protocol, but this + # can break deployment of existing locked bundles when switching between + # different versions of Bundler. The change will be made in 2.0, which + # does not guarantee compatibility with the 1.x series. + # + # See https://github.com/bundler/bundler/pull/2569 for discussion + # + # This can be overridden by adding this code to your Gemfiles: + # + # git_source(:github) do |repo_name| + # repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/") + # "https://github.com/#{repo_name}.git" + # end repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/") "git://github.com/#{repo_name}.git" end |