diff options
author | André Arko <mail@arko.net> | 2015-07-20 11:03:02 -0700 |
---|---|---|
committer | André Arko <mail@arko.net> | 2015-07-20 11:03:02 -0700 |
commit | 61bf0959742493b83107bedca7eec9a989f09781 (patch) | |
tree | f80c8e33c747bdce447260283afb622d8a541710 | |
parent | 880fa0918144b90f1b196a661913072ddfca969a (diff) | |
parent | b7b6d967079e040ad1fc070bf4ebca398ae4f117 (diff) | |
download | bundler-61bf0959742493b83107bedca7eec9a989f09781.tar.gz |
Merge pull request #3856 from bundler/aa-warn-invalid-gemspecs
downgrade invalid specs to a warning for now
-rw-r--r-- | lib/bundler.rb | 3 | ||||
-rw-r--r-- | spec/install/gemfile/path_spec.rb | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/lib/bundler.rb b/lib/bundler.rb index 5970e2c1e4..7059830a46 100644 --- a/lib/bundler.rb +++ b/lib/bundler.rb @@ -371,8 +371,9 @@ module Bundler spec end rescue Gem::InvalidSpecificationException => e - raise InvalidOption, "The gemspec at #{file} is not valid. " \ + Bundler.ui.warn "The gemspec at #{file} is not valid. " \ "The validation error was '#{e.message}'" + nil end def clear_gemspec_cache diff --git a/spec/install/gemfile/path_spec.rb b/spec/install/gemfile/path_spec.rb index b07038136f..a38981150b 100644 --- a/spec/install/gemfile/path_spec.rb +++ b/spec/install/gemfile/path_spec.rb @@ -141,7 +141,7 @@ describe "bundle install with explicit source paths" do should_be_installed "premailer 1.0.0" end - it "errors on invalid specs", :rubygems => "1.7" do + it "warns on invalid specs", :rubygems => "1.7" do build_lib "foo" gemspec = lib_path("foo-1.0").join("foo.gemspec").to_s @@ -158,7 +158,7 @@ describe "bundle install with explicit source paths" do G expect(out).to match(/missing value for attribute version/) - should_not_be_installed("foo 1.0") + expect(out).to_not include("ERROR REPORT") end it "supports gemspec syntax" do |