diff options
| author | The Bundler Bot <bot@bundler.io> | 2017-07-19 20:44:29 +0000 |
|---|---|---|
| committer | The Bundler Bot <bot@bundler.io> | 2017-07-19 20:44:29 +0000 |
| commit | c36fb8b9d7c9008e3801aa342cc14562c865b276 (patch) | |
| tree | da43343c130f4d12965cf7f189a233fffc47876b | |
| parent | 04fd47b1221edabbb46caf34798e5340bc46e1ec (diff) | |
| parent | d6b322fceb131b0bb17d93366dd2b8c754c31595 (diff) | |
| download | bundler-c36fb8b9d7c9008e3801aa342cc14562c865b276.tar.gz | |
Auto merge of #5822 - deivid-rodriguez:dont_gitignore_lockfiles, r=indirect
Stop gitignoring Gemfile.lock in default template
This will be followed up with a documentation PR on some best practices to keep gems tested against up to date dependencies.
### What was the end-user problem that led to this PR?
The problem was that sometimes open source contributors get discouraged because they can't setup the project they want to contribute to easily.
### Was was your diagnosis of the problem?
My diagnosis was that a lot of projects gitignore `Gemfile.lock` just because it's gitignored by default in the new gem template. This causes `bundle install` to no longer be guaranteed to work. And `bundle install` is usually the first step towards a contribution.
### What is your fix for the problem, implemented in this PR?
My fix was to remove the `Gemfile.lock` entry from the gitignore template.
### Why did you choose this fix out of the possible options?
I chose this fix because to prevent a file from being gitignored, removing it from the `.gitignore` file usually does the trick :)
| -rw-r--r-- | lib/bundler/templates/newgem/gitignore.tt | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/bundler/templates/newgem/gitignore.tt b/lib/bundler/templates/newgem/gitignore.tt index 573d76b4c2..b1c9f9986c 100644 --- a/lib/bundler/templates/newgem/gitignore.tt +++ b/lib/bundler/templates/newgem/gitignore.tt @@ -1,6 +1,5 @@ /.bundle/ /.yardoc -/Gemfile.lock /_yardoc/ /coverage/ /doc/ |