summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHomu <homu@barosl.com>2016-05-16 08:54:56 +0900
committerHomu <homu@barosl.com>2016-05-16 08:54:56 +0900
commiteffa1470abb431f652ac33196617777aebf93799 (patch)
tree30fc39468b1b0305a3f85a860e3fbc3ec3bab921
parentc16bf5868585afbef769e72049b6e2ef4447dd6d (diff)
parentd695cb41ee180f1191fa141298a55d7214e91cc5 (diff)
downloadbundler-effa1470abb431f652ac33196617777aebf93799.tar.gz
Auto merge of #4567 - bundler:avoid-tag-or-id-refs-in-commits, r=RochesterinNYC
[Documentation] Add instruction to not use tags or id refs
-rw-r--r--DEVELOPMENT.md6
1 files changed, 6 insertions, 0 deletions
diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md
index 08f1978c07..72d65be838 100644
--- a/DEVELOPMENT.md
+++ b/DEVELOPMENT.md
@@ -60,6 +60,12 @@ Before you submit a pull request, please remember to do the following:
$ bin/rspec spec/bundler
$ bin/rspec spec/commands/update_spec.rb
+- Please ensure that the commit messages included in the pull request __do not__ have the following:
+ - `@tag` Github user or team references (ex. `@indirect` or `@bundler/core`)
+ - `#id` references to issues or pull requests (ex. `#43` or `bundler/bundler-site#12`)
+
+ If you want to use these mechanisms, please instead include them in the pull request description. This prevents multiple notifications or references being created on commit rebases or pull request/branch force pushes.
+
# Bug triage
Triage is the work of processing tickets that have been opened into actionable issues, feature requests, or bug reports. That includes verifying bugs, categorizing the ticket, and ensuring there's enough information to reproduce the bug for anyone who wants to try to fix it.