summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamuel Giddins <segiddins@segiddins.me>2016-12-26 14:58:12 -0600
committerSamuel Giddins <segiddins@segiddins.me>2016-12-26 14:58:12 -0600
commit184f00487aa68504706ae3a2b76aa12bbf56f794 (patch)
treedaea4c25bd92050c1765605493b5bb24ad0e5ecd
parent5609b2c48c60c82484aeda2cc7a3f66cd3d6f09c (diff)
downloadbundler-184f00487aa68504706ae3a2b76aa12bbf56f794.tar.gz
Also check for docs of number & bool keys in the quality spec
-rw-r--r--spec/quality_spec.rb12
1 files changed, 10 insertions, 2 deletions
diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb
index 8492cbb031..9148bf512f 100644
--- a/spec/quality_spec.rb
+++ b/spec/quality_spec.rb
@@ -193,6 +193,7 @@ describe "The library itself" do
it "documents all used settings" do
exemptions = %w(
+ allow_offline_install
auto_install
cache_all
cache_all_platforms
@@ -201,10 +202,14 @@ describe "The library itself" do
disable_exec_load
disable_local_branch_check
disable_shared_gems
+ gem.coc
+ gem.mit
jobs
major_deprecations
no_install
no_prune
+ only_update_to_newer_versions
+ plugins
shebang
silence_root_warning
ssl_verify_mode
@@ -213,14 +218,17 @@ describe "The library itself" do
warned_version
)
- all_settings = {}
+ all_settings = Hash.new {|h, k| h[k] = [] }
documented_settings = exemptions
+ Bundler::Settings::BOOL_KEYS.each {|k| all_settings[k] << "in Bundler::Settings::BOOL_KEYS" }
+ Bundler::Settings::NUMBER_KEYS.each {|k| all_settings[k] << "in Bundler::Settings::NUMBER_KEYS" }
+
Dir.chdir(File.expand_path("../../lib", __FILE__)) do
key_pattern = /([a-z\._-]+)/i
`git ls-files -z`.split("\x0").each do |filename|
File.readlines(filename).each_with_index do |line, number|
- line.scan(/Bundler\.settings\[:#{key_pattern}\]/).flatten.each {|s| (all_settings[s] ||= []) << "referenced at `lib/#{filename}:#{number}`" }
+ line.scan(/Bundler\.settings\[:#{key_pattern}\]/).flatten.each {|s| all_settings[s] << "referenced at `lib/#{filename}:#{number}`" }
end
end
documented_settings = File.read("../man/bundle-config.ronn").scan(/^\* `#{key_pattern}`/).flatten