diff options
| author | The Bundler Bot <bot@bundler.io> | 2017-07-11 12:56:10 +0000 |
|---|---|---|
| committer | The Bundler Bot <bot@bundler.io> | 2017-07-11 12:56:10 +0000 |
| commit | b9851e2fd1d9a2dc7675f713a12c0d4209285d7f (patch) | |
| tree | 8f59748b7e94631f5df07a0a164ed559c8b2969b | |
| parent | 757664c0048a53f65724e76319449680e124d2bc (diff) | |
| parent | 26d6a8240d54f7e3766e49e520b7bd5dbb66c198 (diff) | |
| download | bundler-b9851e2fd1d9a2dc7675f713a12c0d4209285d7f.tar.gz | |
Auto merge of #5855 - bundler:segiddins-spec-deps-update, r=segiddins
Limit specs to rack-test < 0.7.0 for Ruby 1.8.7 compatibility
### What was the end-user problem that led to this PR?
The problem was the specs were broken by the release of `rack-test 0.7.0`.
### What was your diagnosis of the problem?
My diagnosis was `rack-test` has intentionally dropped 1.8.7 support, though we didn't catch that immediately because they didn't put a `required_ruby_version` in their gemspec.
### What is your fix for the problem, implemented in this PR?
My fix pins us to older versions of the gem.
| -rw-r--r-- | spec/support/rubygems_ext.rb | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/spec/support/rubygems_ext.rb b/spec/support/rubygems_ext.rb index cfc481ef83..aa16efceb0 100644 --- a/spec/support/rubygems_ext.rb +++ b/spec/support/rubygems_ext.rb @@ -11,6 +11,9 @@ module Spec # TODO: revert to `< 2` once https://github.com/rack/rack/issues/1168 is # addressed "rack" => "1.6.6", + # rack-test 0.7.0 dropped 1.8.7 support + # https://github.com/rack-test/rack-test/issues/193#issuecomment-314230318 + "rack-test" => "< 0.7.0", "artifice" => "~> 0.6.0", "compact_index" => "~> 0.11.0", "sinatra" => "~> 1.4.7", |