diff options
| author | The Bundler Bot <bot@bundler.io> | 2017-07-11 12:56:10 +0000 |
|---|---|---|
| committer | Samuel Giddins <segiddins@segiddins.me> | 2017-07-17 12:31:48 -0500 |
| commit | 796aa41ad2875190a96dffbc3606f85b1140b20c (patch) | |
| tree | 813af56d2ad2cb0598daee4c461ca9e170d1a29d | |
| parent | 9046162c47fe3bf70088e4bd6434c65bcacc2ac2 (diff) | |
| download | bundler-796aa41ad2875190a96dffbc3606f85b1140b20c.tar.gz | |
Auto merge of #5855 - bundler:segiddins-spec-deps-update, r=segiddins
Limit specs to rack-test < 0.7.0 for Ruby 1.8.7 compatibility
### What was the end-user problem that led to this PR?
The problem was the specs were broken by the release of `rack-test 0.7.0`.
### What was your diagnosis of the problem?
My diagnosis was `rack-test` has intentionally dropped 1.8.7 support, though we didn't catch that immediately because they didn't put a `required_ruby_version` in their gemspec.
### What is your fix for the problem, implemented in this PR?
My fix pins us to older versions of the gem.
(cherry picked from commit b9851e2fd1d9a2dc7675f713a12c0d4209285d7f)
# Conflicts:
# spec/support/rubygems_ext.rb
| -rw-r--r-- | spec/support/rubygems_ext.rb | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/spec/support/rubygems_ext.rb b/spec/support/rubygems_ext.rb index 88886c3f1f..b484d63eab 100644 --- a/spec/support/rubygems_ext.rb +++ b/spec/support/rubygems_ext.rb @@ -9,6 +9,9 @@ module Spec # rack 2.x requires Ruby version >= 2.2.2. # artifice doesn't support rack 2.x now. "rack" => "< 2", + # rack-test 0.7.0 dropped 1.8.7 support + # https://github.com/rack-test/rack-test/issues/193#issuecomment-314230318 + "rack-test" => "< 0.7.0", "artifice" => "~> 0.6.0", "compact_index" => "~> 0.11.0", "sinatra" => "~> 1.4.7", |