summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamuel Giddins <segiddins@segiddins.me>2016-01-14 15:44:26 -0600
committerSamuel Giddins <segiddins@segiddins.me>2016-01-31 22:21:13 -0600
commit9297bcf0135a0bd8c1df29b929267582ca66217d (patch)
tree78ecc4723376e589c9b9bbb2d3da46e7cb0398dd
parente86341047c049cdf7d2a6b10aa025a6633a2d5dd (diff)
downloadbundler-9297bcf0135a0bd8c1df29b929267582ca66217d.tar.gz
[RuboCop] Update todo config for 0.36
-rw-r--r--.rubocop_todo.yml211
1 files changed, 197 insertions, 14 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a97947f794..a56603857f 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2015-11-21 00:03:12 -0600 using RuboCop version 0.35.1.
+# on 2016-01-14 15:41:59 -0600 using RuboCop version 0.36.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
@@ -22,9 +22,15 @@ Lint/HandleExceptions:
- 'lib/bundler/vendored_persistent.rb'
# Offense count: 1
+Lint/IneffectiveAccessModifier:
+ Exclude:
+ - 'lib/bundler/settings.rb'
+
+# Offense count: 4
Lint/NestedMethodDefinition:
Exclude:
- - 'lib/bundler/graph.rb'
+ - 'lib/bundler/inline.rb'
+ - 'spec/support/builders.rb'
# Offense count: 5
Lint/RescueException:
@@ -35,6 +41,11 @@ Lint/RescueException:
- 'lib/bundler/rubygems_integration.rb'
- 'lib/bundler/worker.rb'
+# Offense count: 1
+Lint/UselessAccessModifier:
+ Exclude:
+ - 'lib/bundler/fetcher.rb'
+
# Offense count: 7
Lint/UselessAssignment:
Exclude:
@@ -42,8 +53,9 @@ Lint/UselessAssignment:
- 'lib/bundler/index.rb'
- 'lib/bundler/installer.rb'
-# Offense count: 1031
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 1057
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
Metrics/LineLength:
Max: 207
@@ -52,15 +64,57 @@ Metrics/LineLength:
Metrics/ParameterLists:
Max: 6
-# Offense count: 50
+# Offense count: 53
Metrics/PerceivedComplexity:
Max: 54
+# Offense count: 6
+# Cop supports --auto-correct.
+Performance/RedundantBlockCall:
+ Exclude:
+ - 'lib/bundler/dsl.rb'
+ - 'lib/bundler/gem_helper.rb'
+ - 'lib/bundler/retry.rb'
+ - 'lib/bundler/shared_helpers.rb'
+ - 'spec/support/helpers.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Performance/RedundantMatch:
+ Exclude:
+ - 'lib/bundler/definition.rb'
+ - 'lib/bundler/lockfile_parser.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Performance/RedundantMerge:
+ Exclude:
+ - 'lib/bundler/cli/gem.rb'
+ - 'spec/support/helpers.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/StartWith:
+ Exclude:
+ - 'lib/bundler/cli/config.rb'
+
+# Offense count: 1
+Performance/TimesMap:
+ Exclude:
+ - 'lib/bundler/worker.rb'
+
# Offense count: 1
Style/AccessorMethodName:
Exclude:
- 'lib/bundler/source/git.rb'
+# Offense count: 23
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: prefer_alias, prefer_alias_method
+Style/Alias:
+ Enabled: false
+
# Offense count: 3
Style/CaseEquality:
Exclude:
@@ -70,19 +124,48 @@ Style/CaseEquality:
# Offense count: 22
# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
Style/ClassAndModuleChildren:
Enabled: false
-# Offense count: 119
-# Configuration parameters: Exclude.
+# Offense count: 14
+# Cop supports --auto-correct.
+# Configuration parameters: SingleLineConditionsOnly.
+Style/ConditionalAssignment:
+ Exclude:
+ - 'lib/bundler.rb'
+ - 'lib/bundler/cli.rb'
+ - 'lib/bundler/cli/gem.rb'
+ - 'lib/bundler/cli/lock.rb'
+ - 'lib/bundler/cli/outdated.rb'
+ - 'lib/bundler/cli/platform.rb'
+ - 'lib/bundler/dsl.rb'
+ - 'lib/bundler/lazy_specification.rb'
+ - 'lib/bundler/mirror.rb'
+ - 'lib/bundler/psyched_yaml.rb'
+ - 'lib/bundler/rubygems_integration.rb'
+ - 'lib/bundler/source/git.rb'
+ - 'lib/bundler/source/rubygems.rb'
+
+# Offense count: 122
Style/Documentation:
Enabled: false
-# Offense count: 1
-# Configuration parameters: Exclude.
-Style/FileName:
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+Style/ExtraSpacing:
Exclude:
- - 'lib/bundler/templates/Executable'
+ - 'lib/bundler/cli.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: when_needed, always
+Style/FrozenStringLiteralComment:
+ Exclude:
+ - 'lib/bundler/index.rb'
+ - 'spec/runtime/inline_spec.rb'
# Offense count: 4
# Configuration parameters: AllowedVariables.
@@ -92,10 +175,29 @@ Style/GlobalVars:
- 'spec/spec_helper.rb'
- 'spec/support/helpers.rb'
-# Offense count: 32
+# Offense count: 7
# Configuration parameters: MinBodyLength.
Style/GuardClause:
- Enabled: false
+ Exclude:
+ - 'lib/bundler/cli/config.rb'
+ - 'lib/bundler/cli/viz.rb'
+ - 'lib/bundler/dsl.rb'
+ - 'lib/bundler/fetcher.rb'
+ - 'lib/bundler/fetcher/index.rb'
+ - 'lib/bundler/graph.rb'
+
+# Offense count: 2
+Style/IfInsideElse:
+ Exclude:
+ - 'lib/bundler/cli/install.rb'
+ - 'lib/bundler/definition.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, IndentationWidth.
+# SupportedStyles: special_inside_parentheses, consistent, align_brackets
+Style/IndentArray:
+ EnforcedStyle: consistent
# Offense count: 2
Style/ModuleFunction:
@@ -103,8 +205,42 @@ Style/ModuleFunction:
- 'lib/bundler/shared_helpers.rb'
- 'spec/support/path.rb'
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented
+Style/MultilineMethodCallIndentation:
+ Enabled: false
+
+# Offense count: 24
+# Cop supports --auto-correct.
+Style/MutableConstant:
+ Exclude:
+ - 'lib/bundler/cli.rb'
+ - 'lib/bundler/cli/gem.rb'
+ - 'lib/bundler/fetcher.rb'
+ - 'lib/bundler/gem_helpers.rb'
+ - 'lib/bundler/lockfile_parser.rb'
+ - 'lib/bundler/runtime.rb'
+ - 'lib/bundler/settings.rb'
+ - 'lib/bundler/source/path.rb'
+ - 'lib/bundler/ui/shell.rb'
+ - 'lib/bundler/version.rb'
+
+# Offense count: 8
+Style/NestedParenthesizedCalls:
+ Exclude:
+ - 'lib/bundler/fetcher.rb'
+ - 'lib/bundler/resolver.rb'
+ - 'spec/bundler/shared_helpers_spec.rb'
+ - 'spec/commands/lock_spec.rb'
+ - 'spec/runtime/setup_spec.rb'
+
# Offense count: 8
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
Style/PredicateName:
Exclude:
- 'lib/bundler/definition.rb'
@@ -114,7 +250,54 @@ Style/PredicateName:
- 'lib/bundler/source/git/git_proxy.rb'
- 'lib/bundler/source/path.rb'
-# Offense count: 7
+# Offense count: 9
# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, exploded
Style/RaiseArgs:
Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/RedundantParentheses:
+ Exclude:
+ - 'lib/bundler/cli/console.rb'
+ - 'lib/bundler/dsl.rb'
+ - 'spec/support/ruby_ext.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Style/SpaceAroundOperators:
+ Exclude:
+ - 'lib/bundler/retry.rb'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+# SupportedStyles: comma, consistent_comma, no_comma
+Style/TrailingCommaInLiteral:
+ Exclude:
+ - 'lib/bundler/cli/gem.rb'
+ - 'lib/bundler/dependency.rb'
+ - 'lib/bundler/fetcher.rb'
+ - 'lib/bundler/gem_helpers.rb'
+ - 'lib/bundler/graph.rb'
+ - 'lib/bundler/ruby_version.rb'
+ - 'lib/bundler/similarity_detector.rb'
+ - 'spec/support/artifice/endpoint.rb'
+ - 'spec/support/rubygems_ext.rb'
+
+# Offense count: 20
+# Cop supports --auto-correct.
+Style/UnneededInterpolation:
+ Exclude:
+ - 'lib/bundler/cli/config.rb'
+ - 'lib/bundler/definition.rb'
+ - 'lib/bundler/env.rb'
+ - 'spec/bundler/shared_helpers_spec.rb'
+ - 'spec/cache/git_spec.rb'
+ - 'spec/commands/exec_spec.rb'
+ - 'spec/support/artifice/endpoint.rb'
+ - 'spec/support/artifice/endpoint_500.rb'
+ - 'spec/support/fakeweb/windows.rb'
+ - 'spec/support/rubygems_ext.rb'